Skip to content

Moving towards a whitelist approach for MANIFEST.in#8109

Merged
mistercrunch merged 4 commits intoapache:masterfrom
craig-rueda:manifest_cleanup
Aug 27, 2019
Merged

Moving towards a whitelist approach for MANIFEST.in#8109
mistercrunch merged 4 commits intoapache:masterfrom
craig-rueda:manifest_cleanup

Conversation

@craig-rueda
Copy link
Member

@craig-rueda craig-rueda commented Aug 24, 2019

There's a lot of stuff in assets that doesn't need to be shipped and/or served with Superset. The current setup of MANIFEST.in starts out by doing an initial recursive-include against static and then selectively excludes several items. As a result, several files are being left behind, such as terser caches, .rc files, package.json, etc.

Fixes #8107

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

REVIEWERS

@mistercrunch

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #8109 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8109      +/-   ##
=========================================
+ Coverage   65.89%   65.9%   +<.01%     
=========================================
  Files         485     485              
  Lines       22917   22922       +5     
  Branches     2537    2537              
=========================================
+ Hits        15102   15106       +4     
- Misses       7683    7684       +1     
  Partials      132     132
Impacted Files Coverage Δ
superset/config.py 88.46% <87.5%> (-0.24%) ⬇️
superset/viz.py 71.27% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee75d03...6936c1c. Read the comment docs.

@mistercrunch mistercrunch merged commit de6d963 into apache:master Aug 27, 2019
@amancevice
Copy link

I think this line needs to be changed to use version_info.json:
https://github.com/apache/incubator-superset/blob/master/setup.py#L30

Running pip install <superset-sdist-tarball> is failing for me because there is no package.json in the dist

@bkyryliuk bkyryliuk mentioned this pull request Sep 11, 2019
6 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 First shipped in 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.35.0 First shipped in 0.35.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be more restrictive around assets/static in MANIFEST.in

5 participants