Moving towards a whitelist approach for MANIFEST.in#8109
Merged
mistercrunch merged 4 commits intoapache:masterfrom Aug 27, 2019
Merged
Moving towards a whitelist approach for MANIFEST.in#8109mistercrunch merged 4 commits intoapache:masterfrom
mistercrunch merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8109 +/- ##
=========================================
+ Coverage 65.89% 65.9% +<.01%
=========================================
Files 485 485
Lines 22917 22922 +5
Branches 2537 2537
=========================================
+ Hits 15102 15106 +4
- Misses 7683 7684 +1
Partials 132 132
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Aug 27, 2019
|
I think this line needs to be changed to use Running |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a lot of stuff in
assetsthat doesn't need to be shipped and/or served with Superset. The current setup ofMANIFEST.instarts out by doing an initialrecursive-includeagainststaticand then selectively excludes several items. As a result, several files are being left behind, such as terser caches, .rc files, package.json, etc.Fixes #8107
CATEGORY
Choose one
REVIEWERS
@mistercrunch