bump a set of test-related JS libs #8051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
bump_js_libs
branch
from
40f0ba3
to
647fec2
Compare
mistercrunch
commented
Aug 15, 2019
| @@ -27,7 +27,6 @@ repos: | |||
| - id: trailing-whitespace | |||
| - id: end-of-file-fixer | |||
| - id: check-docstring-first | |||
| - id: check-json | |||
There was a problem hiding this comment.
This was giving me trouble with he .babelrc changes...
mistercrunch
commented
Aug 15, 2019
| @@ -17,6 +17,8 @@ | |||
| * under the License. | |||
| */ | |||
| { | |||
| "sourceMaps": true, | |||
There was a problem hiding this comment.
These 2 lines are the actual fix.
mistercrunch
commented
Aug 15, 2019
| @@ -17,7 +17,8 @@ | |||
| * under the License. | |||
| */ | |||
| /* eslint no-native-reassign: 0 */ | |||
| import '@babel/polyfill'; | |||
There was a problem hiding this comment.
This got deprecated in favor of the new approach described here https://www.npmjs.com/package/@babel/polyfill
Codecov Report
@@ Coverage Diff @@
## master #8051 +/- ##
==========================================
- Coverage 65.56% 65.41% -0.15%
==========================================
Files 469 469
Lines 22480 22485 +5
Branches 2442 2446 +4
==========================================
- Hits 14739 14709 -30
- Misses 7621 7656 +35
Partials 120 120
Continue to review full report at Codecov.
|
mistercrunch
force-pushed
the
bump_js_libs
branch
from
cfa33de
to
16981fc
Compare
kristw
reviewed
Aug 15, 2019
|
@kristw , adjusted to |
Mostly upgrading jest as I was trying to tackle issues related to wrong source-maps reporting in jest. This addresses it
mistercrunch
force-pushed
the
bump_js_libs
branch
from
45dc7bb
to
8bac666
Compare
kristw
approved these changes
Aug 20, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Mostly upgrading jest as I was trying to tackle issues related to
wrong source-maps reporting in jest. The entrance to the rabbit hole is here: jestjs/jest#5446