Skip to content

Conversation

@mistercrunch
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

related to #4725
closes #7865

@codecov-io
Copy link

codecov-io commented Jul 13, 2019

Codecov Report

Merging #7869 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7869      +/-   ##
==========================================
- Coverage   65.77%   65.77%   -0.01%     
==========================================
  Files         461      461              
  Lines       22103    22107       +4     
  Branches     2423     2423              
==========================================
+ Hits        14539    14541       +2     
- Misses       7443     7445       +2     
  Partials      121      121
Impacted Files Coverage Δ
superset/data/deck.py 11.11% <0%> (-0.18%) ⬇️
superset/data/misc_dashboard.py 26.08% <0%> (-1.19%) ⬇️
superset/data/birth_names.py 100% <100%> (ø) ⬆️
superset/data/world_bank.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1197d25...bf590d9. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing similar changes in the following files:

  • unicode_test_data.py
  • tabbed_dashboard.py

@mistercrunch
Copy link
Member Author

Those 2 are more or less used for unit tests, I wanted to publish only the decent example dashboards.

@villebro
Copy link
Member

Those 2 are more or less used for unit tests, I wanted to publish only the decent example dashboards.

Thinking more about this, if these are not considered official example dashboards, perhaps they should be installed using a different command, like superset load_tests or similar?

@mistercrunch
Copy link
Member Author

Changes here now included in #7773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example dashboards are unpublished by default

3 participants