Skip to content

[webpack] revert change to output extension #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ascott merged 2 commits into from
Jul 15, 2016
Merged

[webpack] revert change to output extension #760

ascott merged 2 commits into from
Jul 15, 2016

Conversation

@ascott
Copy link

@ascott ascott commented Jul 13, 2016

didn't notice that this was breaking the app because the .js files were still being served from /dist.

plz review @georgeke

@coveralls
Copy link

coveralls commented Jul 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.139% when pulling 61093d8f6742cdffd1d11fbb8242a4db84b586ca on ascott:alanna-fix-webpack-config into b295436 on airbnb:master.

@mistercrunch
Copy link
Member

mistercrunch commented Jul 14, 2016

master is fixed, I don't think we need this at this point

@ascott
Copy link
Author

ascott commented Jul 14, 2016

hmm, looks like the master version of webpack.config.js is still using .jsx for the entry files: https://github.com/airbnb/caravel/blob/master/caravel/assets/webpack.config.js#L18

@mistercrunch
Copy link
Member

mistercrunch commented Jul 14, 2016

Oh you're right, though you need to change caravel/templates/caravel/dashboard.html to point to the .js as part of this PR.

The current master has standalone and probably other views pointing to .js that are broken (I just checked that). I think the the .jsx also makes it hard for the browser to find the .js.map for debugging properly.

@georgeke
Copy link
Contributor

georgeke commented Jul 14, 2016

Yep, once we change the entry.js to entry.jsx in dashboard.html this should be good.

@coveralls
Copy link

coveralls commented Jul 14, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.185% when pulling 949de71 on ascott:alanna-fix-webpack-config into f034f27 on airbnb:master.

@georgeke
Copy link
Contributor

georgeke commented Jul 15, 2016

lgtm

@ascott ascott merged commit 1fed498 into apache:master Jul 15, 2016
@ascott ascott deleted the alanna-fix-webpack-config branch July 15, 2016 01:19
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@ktmud @zhaoyongjie
refactor: merge core superset-ui packages (apache#768)
a3d4ffc 
1. move translation, connection, query to core (apache#729)
2. update encodable to remove formatter inter-dependency (apache#744)
3. move number-format and time-format to core (apache#730)
4. move superset-ui/dimension to core (apache#732)
5. move superset-ui/color to core (apache#755)
6. move superset-ui/style to core (apache#756)
7. move superset-ui/validator to core (apache#757)
8. move superset-ui/chart-composition to core (apache#759)
9. move superset-ui/chart to core (apache#760)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@ktmud @zhaoyongjie
refactor: merge core superset-ui packages (apache#768)
ecb247f 
1. move translation, connection, query to core (apache#729)
2. update encodable to remove formatter inter-dependency (apache#744)
3. move number-format and time-format to core (apache#730)
4. move superset-ui/dimension to core (apache#732)
5. move superset-ui/color to core (apache#755)
6. move superset-ui/style to core (apache#756)
7. move superset-ui/validator to core (apache#757)
8. move superset-ui/chart-composition to core (apache#759)
9. move superset-ui/chart to core (apache#760)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@ktmud @zhaoyongjie
refactor: merge core superset-ui packages (apache#768)
451c3be 
1. move translation, connection, query to core (apache#729)
2. update encodable to remove formatter inter-dependency (apache#744)
3. move number-format and time-format to core (apache#730)
4. move superset-ui/dimension to core (apache#732)
5. move superset-ui/color to core (apache#755)
6. move superset-ui/style to core (apache#756)
7. move superset-ui/validator to core (apache#757)
8. move superset-ui/chart-composition to core (apache#759)
9. move superset-ui/chart to core (apache#760)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@ktmud @zhaoyongjie
refactor: merge core superset-ui packages (apache#768)
415ce5e 
1. move translation, connection, query to core (apache#729)
2. update encodable to remove formatter inter-dependency (apache#744)
3. move number-format and time-format to core (apache#730)
4. move superset-ui/dimension to core (apache#732)
5. move superset-ui/color to core (apache#755)
6. move superset-ui/style to core (apache#756)
7. move superset-ui/validator to core (apache#757)
8. move superset-ui/chart-composition to core (apache#759)
9. move superset-ui/chart to core (apache#760)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ascott @coveralls @mistercrunch @georgeke