Skip to content

Conversation

@dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 9, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)

SUMMARY

FAB to 2.1.X brings the following relevant topics:

  • It's now possible to override class permission name and method permission name. Useful to aggregate view permissions and reduce the amount of generated view/menu/api, permission pairs.
  • Builtin roles defined on config that support regular expressions
  • flask-sqlalchemy bump to 2.4.0 with more config options

ADDITIONAL INFORMATION

  • Introduces new feature or API

CHANGELOG from FAB since version 2.0.0:

  • Improvements and Bug fixes on 2.1.4

Fix, #1027 API dotted notation joins to same table
Fix, #1012 API default resource name must be lower case
Fix, #1013 Use csrf exempt by default when CSRFProtect is registered has a Flask extension
Fix, #1007 API Support for property decorated functions has models fields
Fix, #1002 Permission mapping
New, #1010 Support for UUID sqlalchemy fields has string fields on WTForms

  • Improvements and Bug fixes on 2.1.3

Fix, Index view override on class instantiation is discarded

  • Improvements and Bug fixes on 2.1.2

Fix, #993 App factory pattern, AppBuilder object can be fully configured using config keys
Fix, #994 If builtin role don't check db also, higher permission on DB would allow access

  • Improvements and Bug fixes on 2.1.1

Fix, #991 Make Admin builtin optional, only if declared on config

  • Improvements and Bug fixes on 2.1.0

New, #977 flask-sqlalchemy bump to 2.4.0 (new config options)
New, #986 Builtin roles using regex, Admin role is now one of these
New, #969 Override class and method permission names and procedure to converge/migrate
Fix, #985 Deprecation warning EOL version was wrong
New, #976 pRison version bump
Fix, #966 Change the default email value for auth_remote_user in security manager

@dpgaspar dpgaspar changed the title [WiP] Bump FAB to 2.1.0 [WiP] Bump FAB to 2.1.1 May 9, 2019
@dpgaspar dpgaspar changed the title [WiP] Bump FAB to 2.1.1 [WiP] Bump FAB to 2.1.2 May 14, 2019
@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #7478 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7478      +/-   ##
==========================================
- Coverage   65.42%   65.26%   -0.16%     
==========================================
  Files         435      435              
  Lines       21325    21485     +160     
  Branches     2347     2379      +32     
==========================================
+ Hits        13951    14023      +72     
- Misses       7258     7342      +84     
- Partials      116      120       +4
Impacted Files Coverage Δ
superset/views/sql_lab.py 85.71% <0%> (-8.93%) ⬇️
superset/assets/src/SqlLab/actions/sqlLab.js 63.31% <0%> (-7.33%) ⬇️
superset/assets/src/SqlLab/reducers/sqlLab.js 50% <0%> (-6.61%) ⬇️
...sets/src/SqlLab/components/ScheduleQueryButton.jsx 8.77% <0%> (-4.57%) ⬇️
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 56.19% <0%> (-3.61%) ⬇️
superset/security.py 75% <0%> (-1.2%) ⬇️
superset/__init__.py 73.52% <0%> (-1.1%) ⬇️
superset/assets/src/components/TableSelector.jsx 84.16% <0%> (-0.52%) ⬇️
superset/views/core.py 72.88% <0%> (-0.05%) ⬇️
...rset/assets/src/SqlLab/reducers/getInitialState.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4392c8...caa8c14. Read the comment docs.

@mistercrunch mistercrunch changed the title [WiP] Bump FAB to 2.1.2 [WiP] Bump FAB to 2.1.3 May 14, 2019
@dpgaspar dpgaspar closed this May 14, 2019
@dpgaspar dpgaspar reopened this May 14, 2019
@dpgaspar dpgaspar changed the title [WiP] Bump FAB to 2.1.3 [WiP] Bump FAB to 2.1.4 Jun 6, 2019
@dpgaspar dpgaspar changed the title [WiP] Bump FAB to 2.1.4 Bump FAB to 2.1.4 Jun 6, 2019
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elukey
Copy link
Contributor

elukey commented Jun 7, 2019

This is great, having all these improvements in the next release would be massive!

@mistercrunch
Copy link
Member

@elukey these features are in the new RestModelView which we're migrating towards.

@elukey
Copy link
Contributor

elukey commented Jun 9, 2019

@mistercrunch thanks a lot for working on this. I don't have a ton of context about the migration towards 2.x for FAB, I am mainly interested in a fix (https://github.com/dpgaspar/Flask-AppBuilder/pull/966/commits) for a recurrent issue that I have in my superset environment. Instead of simply bumping fab to 2.x by myself and rebuild I preferred to wait since IIUC the migration is not as simple as changing the version in requirements.txt :)

@mistercrunch mistercrunch merged commit 6eb60ed into apache:master Jun 10, 2019
@dpgaspar dpgaspar deleted the fab_2.1.0 branch June 10, 2019 10:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants