Change 'timestamp' to '_timestamp_' for Apache Kylin compatibility#724
Closed
lucky2you wants to merge 2 commits intoapache:masterfrom
lucky2you:kylin_timestamp
Closed
Change 'timestamp' to '_timestamp_' for Apache Kylin compatibility#724lucky2you wants to merge 2 commits intoapache:masterfrom lucky2you:kylin_timestamp
lucky2you wants to merge 2 commits intoapache:masterfrom
lucky2you:kylin_timestamp
Conversation
Contributor
|
Hi may be you can try the Caravel-Kylin branch (based on Caravel 0.8.9): |
|
We're trying to connect to a Teradata MPP and we're having the same problem, since 'timestamp' is a reserved keyword. +1 |
Contributor
Author
|
@rocky1001 thanks , it helps a lot! Would you commit your changes to the official repository? |
Contributor
|
@lucky2you If you reviewed the adapter-code in the caravel-kylin branch, you can see the solutions right now is not that good. I'd like to move all the adapter-code to ORM level( in Pykylin ), but really lack of time to finish this. |
Member
|
This LGTM, I just need to test it against our production DB and make sure all is right. |
Member
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
This was referenced Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query is failed when make Apache Kylin as the datasource. The 'timestamp' is a key word in Kylin SQL. So the query "select xxx as timestamp ..." failed. Change 'timestamp' to 'timestamp' to avoid that.