Skip to content

Change 'timestamp' to '_timestamp_' for Apache Kylin compatibility#724

Closed
lucky2you wants to merge 2 commits intoapache:masterfrom
lucky2you:kylin_timestamp
Closed

Change 'timestamp' to '_timestamp_' for Apache Kylin compatibility#724
lucky2you wants to merge 2 commits intoapache:masterfrom
lucky2you:kylin_timestamp

Conversation

@lucky2you
Copy link
Copy Markdown
Contributor

The query is failed when make Apache Kylin as the datasource. The 'timestamp' is a key word in Kylin SQL. So the query "select xxx as timestamp ..." failed. Change 'timestamp' to 'timestamp' to avoid that.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 7, 2016

Coverage Status

Coverage decreased (-0.03%) to 81.005% when pulling 300f147 on lucky2you:kylin_timestamp into 8135c24 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 7, 2016

Coverage Status

Coverage decreased (-0.03%) to 81.005% when pulling 43ef8e1 on lucky2you:kylin_timestamp into 8135c24 on airbnb:master.

@rocky1001
Copy link
Copy Markdown
Contributor

Hi may be you can try the Caravel-Kylin branch (based on Caravel 0.8.9):
https://github.com/rocky1001/caravel/tree/caravel-kylin
which solved most problems when integrated with Kylin.

@mrbungie
Copy link
Copy Markdown

We're trying to connect to a Teradata MPP and we're having the same problem, since 'timestamp' is a reserved keyword. +1

@lucky2you
Copy link
Copy Markdown
Contributor Author

@rocky1001 thanks , it helps a lot! Would you commit your changes to the official repository?

@rocky1001
Copy link
Copy Markdown
Contributor

@lucky2you If you reviewed the adapter-code in the caravel-kylin branch, you can see the solutions right now is not that good. I'd like to move all the adapter-code to ORM level( in Pykylin ), but really lack of time to finish this.

@mistercrunch
Copy link
Copy Markdown
Member

This LGTM, I just need to test it against our production DB and make sure all is right.

@mistercrunch
Copy link
Copy Markdown
Member

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants