Celery task for warming up cache #7148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exclude venv for python linter to ignore * Fix NaN error
This PR sets the background-color css property on `.ace_scroller` instead of `.ace_content` to prevent the white background shown during resizing of the SQL editor before drag ends.
* added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print (cherry picked from commit d5b9795)
(cherry picked from commit 6a4d507)
β¦esh (apache#7027) (cherry picked from commit cc58f0e)
* Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values
(cherry picked from commit 7f3c145)
(cherry picked from commit 05be866)
(cherry picked from commit a6d48d4)
β¦pache#7035) (cherry picked from commit 0782e83)
(cherry picked from commit ead3d48)
β¦g. (apache#7037) * Update datasource.py * Update datasource.py (cherry picked from commit c771625)
(cherry picked from commit 48431ab)
(cherry picked from commit 3e076cb)
* Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric (cherry picked from commit e619405)
(cherry picked from commit 61add60)
β¦he#7082) closes apache#7080 (cherry picked from commit 9b58e9f)
* Fix filter_box migration PR apache#6523 * Fix druid-related bug (cherry picked from commit b210742)
This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd)
(cherry picked from commit e83a07d)
(cherry picked from commit 2ff721a)
(cherry picked from commit 003364e)
Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library (cherry picked from commit 215ed39)
kristw
added
the
enhancement:request
xtinec
force-pushed
the
lyftga
branch
3 times, most recently
from
a15703f to
62cfb2d
Compare
* Exclude venv for python linter to ignore * Fix NaN error
(cherry picked from commit 7f3c145)
This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board (cherry picked from commit 71f1bbd)
Codecov Report
@@ Coverage Diff @@
## lyftga #7148 +/- ##
==========================================
+ Coverage 64.5% 64.57% +0.06%
==========================================
Files 424 425 +1
Lines 20668 20785 +117
Branches 2268 2268
==========================================
+ Hits 13332 13422 +90
- Misses 7213 7240 +27
Partials 123 123
Continue to review full report at Codecov.
|
|
thanks for the work! Let's see how it works and adding more improvements. |
mistercrunch
added
π·οΈ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a REST endpoint for warming up caches β let's use it! π
I wrote a celery task that periodically hits up the endpoint, based on different strategies. I implemented:
More strategies can be easily added.