Skip to content

Conversation

@mistercrunch
Copy link
Member

I left this behind on a previous PR, and it gets kind of crazy on large
SQL statements, so decided it's probably a good thing to clean this up.

I left this behind on a previous PR, and it gets kind of crazy on large
SQL statements, so decided it's probably a good thing to clean this up.
@codecov-io
Copy link

Codecov Report

Merging #7122 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7122      +/-   ##
==========================================
- Coverage   64.61%   64.61%   -0.01%     
==========================================
  Files         422      422              
  Lines       20600    20606       +6     
  Branches     2253     2253              
==========================================
+ Hits        13311    13314       +3     
- Misses       7167     7170       +3     
  Partials      122      122
Impacted Files Coverage Δ
superset/sql_parse.py 99.13% <ø> (-0.01%) ⬇️
superset/connectors/druid/models.py 82.51% <0%> (-0.23%) ⬇️
superset/connectors/druid/views.py 66.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f1bbd...a246ac6. Read the comment docs.

@mistercrunch mistercrunch merged commit 68d2880 into apache:master Mar 26, 2019
@mistercrunch mistercrunch deleted the remove_debug_logging_call branch March 26, 2019 15:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants