Skip to content

Conversation

@john-bodley
Copy link
Member

@john-bodley john-bodley commented Mar 25, 2019

Rather than including all of pyhive's Hive dependencies, it seems more prudent to specify the pyhive extra.

Tested by running pip3 install -e .[hive] to verify all the extra dependencies were installed.

to: @graceguo-supercat @michellethomas @mistercrunch

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #7115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7115   +/-   ##
=======================================
  Coverage   64.59%   64.59%           
=======================================
  Files         422      422           
  Lines       20587    20587           
  Branches     2251     2251           
=======================================
  Hits        13298    13298           
  Misses       7167     7167           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003364e...1d5e811. Read the comment docs.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw merged commit ee36ce8 into apache:master Mar 27, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants