Skip to content

[SQL Lab] Remove double scrollbar from the result tab #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enricoberti wants to merge 1 commit into from
Closed

[SQL Lab] Remove double scrollbar from the result tab #7083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/assets/src/SqlLab/components/ResultSet.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const defaultProps = {
database: {},
};

const SEARCH_HEIGHT = 46;
const SEARCH_HEIGHT = 186;
Copy link
Contributor

@xtinec xtinec Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think the hardcode here is the height of the ResultSetControl div. It appears to be 46 pixels in both Chrome and FF. Are we sure about 186 here?

Copy link
Contributor Author

@enricoberti enricoberti Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it was, the result table was going out of the screen (last row never visible, unless you would scroll the outer panel)

I'm generally against magic numbers in the code though, so we should probably find a proper solution for it (ie calculating the sibling heights after rendering) :)


const LOADING_STYLES = { position: 'relative', minHeight: 100 };

Expand Down
4 changes: 0 additions & 4 deletions superset/assets/src/SqlLab/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,6 @@ div.Workspace {
}

.SqlLab {
.tab-content {
height: 100%;
}

#brace-editor {
height: calc(100% - 51px);
}
Expand Down
2 changes: 1 addition & 1 deletion superset/assets/src/components/FilterableTable/FilterableTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export default class FilterableTable extends PureComponent {
<Table
ref="Table"
headerHeight={headerHeight}
height={height - 2}
height={height - 20}
Copy link
Contributor

@xtinec xtinec Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 20 here?

overscanRowCount={overscanRowCount}
rowClassName={this.rowClassName}
rowHeight={rowHeight}
Expand Down