Skip to content

Filter empty strings or nulls, and add more operators#704

Merged
mistercrunch merged 2 commits intoapache:masterfrom
x4base:filter_nulls
Jul 1, 2016
Merged

Filter empty strings or nulls, and add more operators#704
mistercrunch merged 2 commits intoapache:masterfrom
x4base:filter_nulls

Conversation

@x4base
Copy link
Copy Markdown
Contributor

@x4base x4base commented Jun 30, 2016

Sometimes we want to filter empty strings or nulls. Previously, empty filters are ignored, now empty filters indicate that the user wants to filter empty string or nulls.

<i class="fa fa-info-circle" data-toggle="tooltip"
data-placement="bottom"
title="{{_("Filters are defined using comma delimited strings as in 'US,FR,Other'")}}"></i>
title="{{_("Filters are defined using comma delimited strings as in 'US,FR,Other'")}}. Leave the value field empty to filter empty strings or nulls"></i>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_('Translate me') is used for translation, let's try to encapsulate most strings!

@x4base
Copy link
Copy Markdown
Contributor Author

x4base commented Jul 1, 2016

OK, updated

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 1, 2016

Coverage Status

Coverage decreased (-0.09%) to 81.008% when pulling 2edc106 on x4base:filter_nulls into f407bd4 on airbnb:master.

@mistercrunch mistercrunch merged commit d5b22dd into apache:master Jul 1, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants