Split tags migration #7002
Merged
Split tags migration #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the iteration over charts, dashboards and saved queries to create tags in the original migration, leaving only the logic to create the tags and the tagged objects tables. Tested locally by running `superset db downgrade` to revert to the previous migration and then running `superset db upgrade` to the current version.
xtinec
added
!deprecated-label:bug
Codecov Report
@@ Coverage Diff @@
## master #7002 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 421 421
Lines 20521 20521
Branches 2245 2245
=======================================
Hits 13229 13229
Misses 7165 7165
Partials 127 127Continue to review full report at Codecov.
|
xtinec
added a commit
that referenced
this pull request
Mar 9, 2019
This PR removes the iteration over charts, dashboards and saved queries to create tags in the original migration, leaving only the logic to create the tags and the tagged objects tables. Tested locally by running `superset db downgrade` to revert to the previous migration and then running `superset db upgrade` to the current version. (cherry picked from commit e47a1b2)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the iteration over charts, dashboards and saved queries to create tags in the original migration, leaving only the logic to create the tags and the tagged objects tables.
Tested locally by running
superset db downgradeto revert to the previous migration and then runningsuperset db upgradeto the current version.