Skip to content

Conversation

@1AB9502
Copy link

@1AB9502 1AB9502 commented Mar 7, 2019

This pull requests fixes an issue where columns defined as groupable only, show up in the filters as well

Fixes this issue #6949

@1AB9502 1AB9502 changed the title Fix groupable only columns populating in filters [WIP] Fix groupable only columns populating in filters Mar 7, 2019
@1AB9502 1AB9502 changed the title [WIP] Fix groupable only columns populating in filters Fix groupable only columns populating in filters Mar 7, 2019
@1AB9502 1AB9502 marked this pull request as ready for review March 7, 2019 18:26
@jdbertron
Copy link

Yay.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #6993 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6993   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files         421      421           
  Lines       20521    20521           
  Branches     2245     2245           
=======================================
  Hits        13229    13229           
  Misses       7165     7165           
  Partials      127      127
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 42.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b48a9...e1f69e7. Read the comment docs.

@mistercrunch
Copy link
Member

mistercrunch commented Mar 8, 2019

This LGTM and is the intended behavior, though leaving open for a moment to leave others the opportunity to chime in.

@kristw kristw added !deprecated-label:bug Deprecated label - Use #bug instead .ui labels Mar 15, 2019
@kristw kristw merged commit f760ba8 into apache:master Mar 15, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants