Skip to content

Conversation

@kristw
Copy link
Contributor

@kristw kristw commented Mar 5, 2019

  • bump @superset-ui and @superset-ui-plugins versions to 0.10.x.
  • use @superset-ui/dimension to compute text dimension and remove the local visUtil.js.
  • remove wrapSvgText function that is no longer used in the main repo. (It has been moved into the plugins repo)
  • fix a few linting issues

@williaster @xtinec @mistercrunch @khtruong @betodealmeida

@kristw kristw changed the title refactor: bump @superset-ui versions [wip] refactor: bump @superset-ui versions Mar 6, 2019
@kristw kristw force-pushed the kristw--bump-version branch from 9e4446f to 6ba96d8 Compare March 6, 2019 17:46
@codecov-io
Copy link

Codecov Report

Merging #6982 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6982     +/-   ##
=========================================
+ Coverage   64.38%   64.49%   +0.1%     
=========================================
  Files         421      420      -1     
  Lines       20574    20508     -66     
  Branches     2251     2241     -10     
=========================================
- Hits        13247    13227     -20     
+ Misses       7194     7154     -40     
+ Partials      133      127      -6
Impacted Files Coverage Δ
...ets/src/visualizations/TimeTable/SparklineCell.jsx 0% <ø> (ø) ⬆️
superset/assets/src/components/AsyncSelect.jsx 96.29% <ø> (ø) ⬆️
superset/assets/src/setup/setupFormatters.js 0% <ø> (ø) ⬆️
superset/assets/src/components/TableLoader.jsx 6.66% <ø> (ø) ⬆️
superset/assets/src/modules/utils.js 60% <ø> (+24.4%) ⬆️
...src/components/FilterableTable/FilterableTable.jsx 90.24% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ba914...6ba96d8. Read the comment docs.

@kristw kristw changed the title [wip] refactor: bump @superset-ui versions refactor: bump @superset-ui versions Mar 6, 2019
@kristw kristw added review enhancement:request Enhancement request submitted by anyone from the community and removed #code-quality labels Mar 6, 2019
@kristw kristw merged commit 23f4c95 into apache:master Mar 7, 2019
@kristw kristw deleted the kristw--bump-version branch March 7, 2019 06:30
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants