-
Notifications
You must be signed in to change notification settings - Fork 16.6k
[dashboard editor] use the theme's btn-primary #6859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6859 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 527 527
Lines 23529 23529
Branches 2782 2782
=======================================
Hits 13251 13251
Misses 9866 9866
Partials 412 412Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #6859 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 527 527
Lines 23529 23529
Branches 2782 2782
=======================================
Hits 13251 13251
Misses 9866 9866
Partials 412 412Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #6859 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 527 527
Lines 23529 23529
Branches 2782 2782
=======================================
Hits 13251 13251
Misses 9866 9866
Partials 412 412Continue to review full report at Codecov.
|
|
@elibrumbaugh do you have thoughts on this? |
|
originally this was meant to enable going to a more minimal design system, but priorities may have shifted since then. I don't have a strong opinion on it. |
|
I also don't have a strong opinion, I just want a single consistent |
|
closes #6891 |
|
@elibrumbaugh ping |
|
I'm going to merge this since it's been open for 21 days. I'm ok to revert if needed. |
I'm not sure why
btn-primarywas made black for dashboard specifically, but want to bring back consistency.before
after