Skip to content

Conversation

@mistercrunch
Copy link
Member

closes #6853

@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #6857 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6857      +/-   ##
==========================================
+ Coverage   64.76%   64.78%   +0.01%     
==========================================
  Files         421      421              
  Lines       20384    20393       +9     
  Branches     2249     2249              
==========================================
+ Hits        13202    13211       +9     
  Misses       7049     7049              
  Partials      133      133
Impacted Files Coverage Δ
superset/db_engine_specs.py 57.03% <100%> (+0.27%) ⬆️
superset/connectors/sqla/models.py 81.86% <100%> (+0.06%) ⬆️
superset/assets/src/chart/chartAction.js 45.23% <0%> (ø) ⬆️
superset/views/core.py 74.94% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ef1a0...9cde526. Read the comment docs.

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistercrunch that could be a good idea. According to the Druid SQL docs __time seems to be the only implicit time column.

@mistercrunch
Copy link
Member Author

@john-bodley I integrated your comments

@kristw kristw added !deprecated-label:bug Deprecated label - Use #bug instead change:backend Requires changing the backend labels Mar 4, 2019
@mistercrunch mistercrunch merged commit ed79134 into apache:master Mar 5, 2019
@mistercrunch mistercrunch deleted the auto_is_dttm branch March 5, 2019 04:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

superset fails to auto-detect time field from druid as sql

4 participants