-
Notifications
You must be signed in to change notification settings - Fork 16.6k
auto-set 'Is Temporal' to true where column_name == '__time' #6857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
03599f8 to
d851e56
Compare
Codecov Report
@@ Coverage Diff @@
## master #6857 +/- ##
==========================================
+ Coverage 64.76% 64.78% +0.01%
==========================================
Files 421 421
Lines 20384 20393 +9
Branches 2249 2249
==========================================
+ Hits 13202 13211 +9
Misses 7049 7049
Partials 133 133
Continue to review full report at Codecov.
|
john-bodley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistercrunch that could be a good idea. According to the Druid SQL docs __time seems to be the only implicit time column.
d851e56 to
26dbc3a
Compare
|
@john-bodley I integrated your comments |
closes #6853