creating new circular-json safe stringify and replacing one call#6772
Merged
betodealmeida merged 1 commit intoapache:masterfrom Jan 29, 2019
Merged
creating new circular-json safe stringify and replacing one call#6772betodealmeida merged 1 commit intoapache:masterfrom
betodealmeida merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6772 +/- ##
===========================================
- Coverage 73.42% 56.09% -17.34%
===========================================
Files 75 526 +451
Lines 10084 23230 +13146
Branches 0 2779 +2779
===========================================
+ Hits 7404 13030 +5626
- Misses 2680 9791 +7111
- Partials 0 409 +409
Continue to review full report at Codecov.
|
Member
|
This looks great! Thanks for the unit tests, and for adding the ASF headers. I'm fine with changing other calls in a later PR. |
Member
|
LGTM |
xtinec
pushed a commit
that referenced
this pull request
Feb 5, 2019
(cherry picked from commit 11a7ad0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one instance of #6761
Why not replace every call to JSON.stringify in this PR?
Creating a time-series table using sample data without the PR:

Creating a time-series table using sample data with this PR:
