Skip to content

Redirect to druid datasource page when the user wants to add slice. Also, provide a link to the table page #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistercrunch merged 1 commit into from
Jun 15, 2016
Merged

Redirect to druid datasource page when the user wants to add slice. Also, provide a link to the table page #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions caravel/templates/caravel/add_slice.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script>
var msg = "Click on a table link to create a Slice";
window.location = "/r/msg/?url={{ '/tablemodelview/list/' }}&msg=" + msg;
var msg = "Click on a datasource link to create a Slice, " +
"or click on a table link <a href='/tablemodelview/list/'>here</a> " +
"to create a Slice for a table";
window.location = "/r/msg/?url={{ '/druiddatasourcemodelview/list/' }}&msg=" + msg;
</script>
2 changes: 1 addition & 1 deletion caravel/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ def shortner(self):
@expose("/msg/")
def msg(self):
"""Redirects to specified url while flash a message"""
flash(request.args.get("msg"), "info")
flash(Markup(request.args.get("msg")), "info")
return redirect(request.args.get("url"))

appbuilder.add_view_no_menu(R)
Expand Down