Skip to content

Make time grains translatable#622

Merged
mistercrunch merged 2 commits intoapache:masterfrom
xrmx:transmodels
Jun 17, 2016
Merged

Make time grains translatable#622
mistercrunch merged 2 commits intoapache:masterfrom
xrmx:transmodels

Conversation

@xrmx
Copy link
Copy Markdown
Contributor

@xrmx xrmx commented Jun 15, 2016

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2016

Coverage Status

Coverage increased (+0.006%) to 81.968% when pulling 8b37fb0e6012f4fb15881c554e8764533d696f3c on xrmx:transmodels into e29d71d on airbnb:master.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait that means you made everything else that didn't need to be lazy use lazy_gettext

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other two users which are exceptions should be fine.

@mistercrunch
Copy link
Copy Markdown
Member

Ooops, I can't merge, can you rebase?

@xrmx
Copy link
Copy Markdown
Contributor Author

xrmx commented Jun 16, 2016

Done

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2016

Coverage Status

Coverage increased (+0.006%) to 81.947% when pulling 3da516c on xrmx:transmodels into 04388a7 on airbnb:master.

@mistercrunch mistercrunch merged commit 4400c70 into apache:master Jun 17, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 First shipped in 0.10.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 First shipped in 0.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants