Skip to content

Order by clause with Hive causes performance degradation.#454

Closed
grafke wants to merge 4 commits intoapache:masterfrom
grafke:master
Closed

Order by clause with Hive causes performance degradation.#454
grafke wants to merge 4 commits intoapache:masterfrom
grafke:master

Conversation

@grafke
Copy link
Copy Markdown
Contributor

@grafke grafke commented May 10, 2016

Order by clause with Hive causes performance degradation. It doesn't really do anything else except on some cases causes queries to fail. I'm not sure if this is the right way to fix it, but on the other hand disabling order by really helps with performance. Otherwise, perhaps it would be wise to add an order by button to the web interface. So that the user could control it.

Paulius Klyvis added 3 commits May 10, 2016 17:04
…ase the query will fail. eg. SELECT columnA AS columnA, columnB AS `timestamp`, SUM(columnC) AS sum__columnC FROM table <...> GROUP BY columnA, columnB ORDER BY SUM(columnC) DESC -- Invalid clause;
@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.14% when pulling e791bff on grafke:master into 2f64c42 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 10, 2016

Coverage Status

Coverage decreased (-0.004%) to 81.58% when pulling 713d895 on grafke:master into 2f64c42 on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

Wait. That order_by is there for a reason, it enforces the "Series limit". Also using Hive as a Caravel backend is probably not a great experience. You probably want to use Presto or Impala instead.

@coveralls
Copy link
Copy Markdown

coveralls commented May 10, 2016

Coverage Status

Coverage decreased (-0.004%) to 81.58% when pulling 713d895 on grafke:master into 2f64c42 on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 713d895 on grafke:master into 2f64c42 on airbnb:master.

@grafke
Copy link
Copy Markdown
Contributor Author

grafke commented May 10, 2016

I see, yes, good point. I agree Hive is not the best choice. Would it be OK to add an if clause, i.e. if Hive then don't do the ordering?

@mistercrunch
Copy link
Copy Markdown
Member

Series Limit would then act as randomly selected set of series, and only for Hive? Makes no sense to me.

@grafke
Copy link
Copy Markdown
Contributor Author

grafke commented May 12, 2016

You're absulutely right, but the subselect on Hive at the moment does not
work anyway. Any plans on adding Hive support? I'm sure we could find a way
to make it work with Hive.
On Thu, 12 May 2016 at 02:50, Maxime Beauchemin notifications@github.com
wrote:

Series Limit would then act as randomly selected set of series, and only
for Hive? Makes no sense to me.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#454 (comment)

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* word cloud control panel

* oops, control panel should actually be used
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* word cloud control panel

* oops, control panel should actually be used
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* word cloud control panel

* oops, control panel should actually be used
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* word cloud control panel

* oops, control panel should actually be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants