Skip to content

add timestamp toggle in chart options (Table Viz)#439

Merged
mistercrunch merged 5 commits intoapache:masterfrom
sid88in:tablevizenhance
May 10, 2016
Merged

add timestamp toggle in chart options (Table Viz)#439
mistercrunch merged 5 commits intoapache:masterfrom
sid88in:tablevizenhance

Conversation

@sid88in
Copy link
Copy Markdown
Contributor

@sid88in sid88in commented May 6, 2016

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2016

Coverage Status

Coverage remained the same at 81.57% when pulling 80b0818 on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 80b0818 on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2016

Coverage Status

Coverage remained the same at 81.57% when pulling 80b0818 on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@sid88in
Copy link
Copy Markdown
Contributor Author

sid88in commented May 6, 2016

screen shot 2016-05-05 at 6 33 06 pm

Comment thread caravel/forms.py Outdated
'table_timestamp_format': FreeFormSelectField(
'Table Timestamp Format',
default='smart_date',
choices=[
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not copy pasta. Can you refactor the choices for this and x_axis_timeformat in a CONSTANT at the top of the module?

@sid88in
Copy link
Copy Markdown
Contributor Author

sid88in commented May 6, 2016

@mistercrunch fixed the refactoring of timestamp choices.

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.03% when pulling 20c00b5 on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 7cc65bb on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2016

Coverage Status

Coverage increased (+0.02%) to 81.59% when pulling 7cc65bb on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2016

Coverage Status

Coverage increased (+0.02%) to 81.59% when pulling 7cc65bb on sid88in:tablevizenhance into d304ee0 on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 61ce364 on sid88in:tablevizenhance into 2f64c42 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2016

Coverage Status

Coverage increased (+0.007%) to 81.59% when pulling 61ce364 on sid88in:tablevizenhance into 2f64c42 on airbnb:master.

@mistercrunch mistercrunch merged commit a75d6bc into apache:master May 10, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.195 to 0.0.196.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.195...v0.0.196)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.195 to 0.0.196.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.195...v0.0.196)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.195 to 0.0.196.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.195...v0.0.196)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.195 to 0.0.196.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.195...v0.0.196)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 First shipped in 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 First shipped in 0.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants