Druid v0.6 compatibility (second try) #4329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just a couple of thoughts:
|
Member
|
@xrmx doesn't have SQL support at all. I think SQLAlchemy access to druid might require |
mistercrunch
requested changes
Feb 2, 2018
Member
mistercrunch
left a comment
mistercrunch
left a comment
There was a problem hiding this comment.
Can we just reference self.cluster.druid_version instead of passing it around?
| col_obj.count_distinct = True | ||
| # Allow sum/min/max for long or double | ||
| if datatype == 'LONG' or datatype == 'DOUBLE': | ||
| if datatype == 'LONG' or datatype == 'DOUBLE' or datatype == 'FLOAT': |
Member
There was a problem hiding this comment.
let's use datetype in ('foo', 'bar')
| ).format(obj=self) | ||
| return json.loads(requests.get(endpoint).text)['version'] | ||
| ver = json.loads(requests.get(endpoint).text)['version'] | ||
| if ver is None: |
Member
There was a problem hiding this comment.
return ver or "0" instead of the 4 lines
kristw
added
enhancement:request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allowed me to set up latest superset with our company's Druid v0.6 cluster. I have tried not to break anything for any newer versions.
This is second try for those changes to merge into upstream, first pull request was here #2331.