Rename the dummy variable _ to avoid conflict with lazy_gettext#427
Rename the dummy variable _ to avoid conflict with lazy_gettext#427mistercrunch merged 1 commit intoapache:masterfrom
Conversation
Otherwise "local variable '_' referenced before assignment" will be raised
|
|
|
Hmmm, |
|
Surely I know it's a convention, but I won't bother to fix it if it hasn't caused any problem. You can decide whether you prefer __, unused, or dummy. Here is the stack trace.
|
|
And coveralls warned about this: https://landscape.io/diff/340487/fixed |
|
Oh I didn't see the scope issue. Merging. |
* feat: migrate xy-chart to use encodable (apache#420) * feat: use encodable in BoxPlot * feat: migrate legend * docs: update storybook * fix: label overlap * fix: lint * fix: remove comments * fix: path * feat: migrate scatterplot to use encodable (apache#421) * feat: migrate scatter plot (cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d) * fix: legend * feat: migrate line chart to use encodable (apache#427) * feat: migrate line to use encodable * fix: storybook ts * fix: remove comment * refactor: delete deprecated files (apache#430) * refactor: delete outdated files * feat: update index exports and add test * refactor: delete more files * fix: import order * fix: update dependency * fix: update dependency * build: fix babel * fix: remvoe comments * fix: babel * refactor: move files (apache#432) * refactor: move files * refactor: move files * fix: small issues with charts post-migration (apache#433) * fix: scatterplot issue * fix: bump encodable and fix time scale nicing * fix: issue with label rotation * refactor: remove deep import * fix: demo import * feat: bump and remove unnecessary dependencies (apache#436) * feat: bump dependencies * feat: remove unnecessary dependencies
* chore: rename directory * chore: correct naming
* feat: migrate xy-chart to use encodable (apache#420) * feat: use encodable in BoxPlot * feat: migrate legend * docs: update storybook * fix: label overlap * fix: lint * fix: remove comments * fix: path * feat: migrate scatterplot to use encodable (apache#421) * feat: migrate scatter plot (cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d) * fix: legend * feat: migrate line chart to use encodable (apache#427) * feat: migrate line to use encodable * fix: storybook ts * fix: remove comment * refactor: delete deprecated files (apache#430) * refactor: delete outdated files * feat: update index exports and add test * refactor: delete more files * fix: import order * fix: update dependency * fix: update dependency * build: fix babel * fix: remvoe comments * fix: babel * refactor: move files (apache#432) * refactor: move files * refactor: move files * fix: small issues with charts post-migration (apache#433) * fix: scatterplot issue * fix: bump encodable and fix time scale nicing * fix: issue with label rotation * refactor: remove deep import * fix: demo import * feat: bump and remove unnecessary dependencies (apache#436) * feat: bump dependencies * feat: remove unnecessary dependencies
* chore: rename directory * chore: correct naming
* feat: migrate xy-chart to use encodable (apache#420) * feat: use encodable in BoxPlot * feat: migrate legend * docs: update storybook * fix: label overlap * fix: lint * fix: remove comments * fix: path * feat: migrate scatterplot to use encodable (apache#421) * feat: migrate scatter plot (cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d) * fix: legend * feat: migrate line chart to use encodable (apache#427) * feat: migrate line to use encodable * fix: storybook ts * fix: remove comment * refactor: delete deprecated files (apache#430) * refactor: delete outdated files * feat: update index exports and add test * refactor: delete more files * fix: import order * fix: update dependency * fix: update dependency * build: fix babel * fix: remvoe comments * fix: babel * refactor: move files (apache#432) * refactor: move files * refactor: move files * fix: small issues with charts post-migration (apache#433) * fix: scatterplot issue * fix: bump encodable and fix time scale nicing * fix: issue with label rotation * refactor: remove deep import * fix: demo import * feat: bump and remove unnecessary dependencies (apache#436) * feat: bump dependencies * feat: remove unnecessary dependencies
* chore: rename directory * chore: correct naming
* feat: migrate xy-chart to use encodable (apache#420) * feat: use encodable in BoxPlot * feat: migrate legend * docs: update storybook * fix: label overlap * fix: lint * fix: remove comments * fix: path * feat: migrate scatterplot to use encodable (apache#421) * feat: migrate scatter plot (cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d) * fix: legend * feat: migrate line chart to use encodable (apache#427) * feat: migrate line to use encodable * fix: storybook ts * fix: remove comment * refactor: delete deprecated files (apache#430) * refactor: delete outdated files * feat: update index exports and add test * refactor: delete more files * fix: import order * fix: update dependency * fix: update dependency * build: fix babel * fix: remvoe comments * fix: babel * refactor: move files (apache#432) * refactor: move files * refactor: move files * fix: small issues with charts post-migration (apache#433) * fix: scatterplot issue * fix: bump encodable and fix time scale nicing * fix: issue with label rotation * refactor: remove deep import * fix: demo import * feat: bump and remove unnecessary dependencies (apache#436) * feat: bump dependencies * feat: remove unnecessary dependencies
* chore: rename directory * chore: correct naming
Otherwise "local variable '_' referenced before assignment" will be raised