[bugfix] allow repeated values across levels when building sunburst hierarchy#414
Merged
williaster merged 1 commit intomasterfrom Apr 29, 2016
Merged
Conversation
Member
|
👍 |
298b989 to
a422d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in some cases when there are repeated values across sunburst levels, nodes for a given sequence were not always added to the correct level
e.g.,
a --> b --> b --> a
b --> a
to prevent this, this PR enforces matching level within a sequence, in addition to matching node names, when building out the sunburst hierarchy.
before

after
