Skip to content

[bugfix] allow repeated values across levels when building sunburst hierarchy#414

Merged
williaster merged 1 commit intomasterfrom
chris/fix-sunburst-level-trunc
Apr 29, 2016
Merged

[bugfix] allow repeated values across levels when building sunburst hierarchy#414
williaster merged 1 commit intomasterfrom
chris/fix-sunburst-level-trunc

Conversation

@williaster
Copy link
Copy Markdown
Contributor

in some cases when there are repeated values across sunburst levels, nodes for a given sequence were not always added to the correct level
e.g.,
a --> b --> b --> a
b --> a

to prevent this, this PR enforces matching level within a sequence, in addition to matching node names, when building out the sunburst hierarchy.

before
screen shot 2016-04-28 at 9 29 53 pm

after
screen shot 2016-04-28 at 9 29 43 pm

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 298b989 on airbnb:chris/fix-sunburst-level-trunc into 77e4d4b on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2016

Coverage Status

Coverage remained the same at 80.986% when pulling 298b989 on chris/fix-sunburst-level-trunc into 77e4d4b on master.

@mistercrunch
Copy link
Copy Markdown
Member

👍

@williaster williaster force-pushed the chris/fix-sunburst-level-trunc branch from 298b989 to a422d1b Compare April 29, 2016 16:44
@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling a422d1b on airbnb:chris/fix-sunburst-level-trunc into 77e4d4b on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2016

Coverage Status

Coverage remained the same at 80.986% when pulling a422d1b on chris/fix-sunburst-level-trunc into 77e4d4b on master.

@williaster williaster merged commit b78ec54 into master Apr 29, 2016
@williaster williaster deleted the chris/fix-sunburst-level-trunc branch April 29, 2016 17:59
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 First shipped in 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 First shipped in 0.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants