Skip to content

Fix USA's state geojson for 'Country Map' visualization#4121

Merged
mistercrunch merged 3 commits intoapache:masterfrom
mistercrunch:fix_usa_geojson
Jan 3, 2018
Merged

Fix USA's state geojson for 'Country Map' visualization#4121
mistercrunch merged 3 commits intoapache:masterfrom
mistercrunch:fix_usa_geojson

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Dec 26, 2017

Turns out the ISO codes were missing from the geojson file, this adds it
and uses human-readable indents.

fixes #4112

@hughhhh
Copy link
Member

hughhhh commented Dec 27, 2017

🚢

Copy link

@mjdepalma mjdepalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change with 0.22, but it unfortunately does not fix the problem. From what I can see, the issue is that the file does not use the official ISO 3166-2 codes as the old country map did. For example, the code being used for Georgia is GA rather than US-GA. The old map format worked with US-GA, but this one does not. If my assumption is correct that all codes need the country dash prefix, then I believe the only remaining change would be to add the "US-" in front of all ISO codes in the file. For reference, please see http://www.statemaster.com/graph/ide_iso_316_cod_sor_by_nam_sta-us-codes-sorted-name-states

@mistercrunch
Copy link
Member Author

Yeah I have to admit I considered both options while writing the PR. I think it's much more common to have the 2-letter code in databases for US states, but it's true that ISO3166-2 has a US- prefix. I'll adapt this to match ISO3166-2

Turns out the ISO codes were missing from the geojson file, this adds it
and uses human-readable indents.
New linting rules started applying, I'm guessing a new version of
pylint?
@mistercrunch mistercrunch merged commit 3720509 into apache:master Jan 3, 2018
@mistercrunch mistercrunch deleted the fix_usa_geojson branch January 3, 2018 04:21
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Fix USA's state geojson for 'Country Map' visualization

Turns out the ISO codes were missing from the geojson file, this adds it
and uses human-readable indents.

* using proper ISO codes

* Linting

New linting rules started applying, I'm guessing a new version of
pylint?
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Fix USA's state geojson for 'Country Map' visualization

Turns out the ISO codes were missing from the geojson file, this adds it
and uses human-readable indents.

* using proper ISO codes

* Linting

New linting rules started applying, I'm guessing a new version of
pylint?
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 First shipped in 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 First shipped in 0.23.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[country map] Country Map updates from #3946 broke USA map

3 participants