Allow underscores in slugs #3951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Nov 29, 2017
Member
john-bodley
left a comment
john-bodley
left a comment
There was a problem hiding this comment.
@michellethomas _ isn't a special character and thus I don't think it should be escaped.
michellethomas
force-pushed
the
fix_slug_underscore
branch
from
242afe6 to
46654f6
Compare
Contributor
Author
|
Fixed, thanks |
Member
|
LGTM |
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Allow underscores in slugs * Switching regex to use shorter \w
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Allow underscores in slugs * Switching regex to use shorter \w
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in this PR we updated the slug function to remove anything that is not a character, number, or hyphen. I think we should also allow underscores in the slug.
The wiki article mentions that underscores or hyphens would be appropriate in a slug.
A number of users here currently use underscores in slugs, especially for the templated links in the time table viz (like /superset/dashboard/dashboard_{{metric }}) where the metric would have an underscore). So when they edit dashboards the underscores get removed and their links no longer work.
@mistercrunch @john-bodley