Skip to content

fix(sqllab): format_sql to apply db dialect by database_id#39393

Merged
michael-s-molina merged 5 commits into
apache:masterfrom
justinpark:fix--missing-engine-on-format-sql
Apr 16, 2026
Merged

fix(sqllab): format_sql to apply db dialect by database_id#39393
michael-s-molina merged 5 commits into
apache:masterfrom
justinpark:fix--missing-engine-on-format-sql

format fix

745c466
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 15, 2026 in 1s

64.47% (-0.01%) compared to 0d91f5e

View this Pull Request on Codecov

64.47% (-0.01%) compared to 0d91f5e

Details

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.47%. Comparing base (0d91f5e) to head (745c466).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
superset/sqllab/api.py 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39393      +/-   ##
==========================================
- Coverage   64.48%   64.47%   -0.01%     
==========================================
  Files        2556     2557       +1     
  Lines      132855   132924      +69     
  Branches    30860    30866       +6     
==========================================
+ Hits        85665    85700      +35     
- Misses      45699    45733      +34     
  Partials     1491     1491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.