fix(gtf): set dedup_key on atomic sql#37820
Conversation
villebro
requested review from
eschutho,
geido,
kgabryje,
michael-s-molina and
rusackas
as code owners
Code Review Agent Run #614810Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37820 +/- ##
===========================================
+ Coverage 0 66.67% +66.67%
===========================================
Files 0 671 +671
Lines 0 51597 +51597
Branches 0 5771 +5771
===========================================
+ Hits 0 34403 +34403
- Misses 0 15810 +15810
- Partials 0 1384 +1384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
villebro
force-pushed
the
villebro/gtf-fixes-1
branch
2 times, most recently
from
a131c33 to
8effcd0
Compare
Code Review Agent Run #98929dActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
villebro
force-pushed
the
villebro/gtf-fixes-1
branch
from
8effcd0 to
e6fee4e
Compare
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #8b1382
Actionable Suggestions - 1
-
superset/tasks/schemas.py - 1
- Inaccurate API field description · Line 28-30
Review Details
-
Files reviewed - 8 · Commit Range:
e6fee4e..c880fb7- superset-core/src/superset_core/api/tasks.py
- superset/daos/tasks.py
- superset/models/tasks.py
- superset/tasks/manager.py
- superset/tasks/schemas.py
- tests/integration_tests/tasks/test_sync_join_wait.py
- tests/unit_tests/daos/test_tasks.py
- tests/unit_tests/tasks/test_manager.py
-
Files skipped - 1
- docs/developer_portal/extensions/tasks.md - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| dedup_key_description = ( | ||
| "The hashed deduplication key used internally for task deduplication" | ||
| ) |
There was a problem hiding this comment.
The dedup_key description claims it's always 'hashed', but for finished tasks, it's set to the task's UUID string. This could mislead API consumers about the field's format.
Code suggestion
Check the AI-generated fix before applying
| dedup_key_description = ( | |
| "The hashed deduplication key used internally for task deduplication" | |
| ) | |
| dedup_key_description = ( | |
| "The deduplication key used internally for task deduplication" | |
| ) |
Code Review Run #8b1382
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
2 participants
SUMMARY
A few fixes to the initial GTF implementation in #36368 :
dedup_key, making completed tasks blocking. This fixes the issue, adds unit tests and addsdedup_keyto the task schema for easier debugging.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION