Skip to content

fix(native-filters): align refresh icon with default value field#37802

Merged
EnxDev merged 1 commit intomasterfrom
enxdev/fix/filter-select-refresh-icon
Feb 11, 2026
Merged

fix(native-filters): align refresh icon with default value field#37802
EnxDev merged 1 commit intomasterfrom
enxdev/fix/filter-select-refresh-icon

Conversation

@EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Feb 9, 2026

SUMMARY

The SyncOutlined refresh icon in the filter config form's "Default Value" row was vertically misaligned when a validation error message appeared below the field. The DefaultValueContainer used align-items: center, which centered the icon relative to the combined height of the field + error message, pushing it below the field line.

Changed align-items from center to flex-start so the icon stays anchored at field level, and added margin-top to vertically center it with the 32px input.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
Screenshot 2026-02-09 132445
  • After
Screenshot 2026-02-09 132324
  • Before
Screenshot 2026-02-09 132451
  • After
Screenshot 2026-02-09 132334

TESTING INSTRUCTIONS

  1. Go to a dashboard → Edit → Filters
  2. Select or create a filter with a dataset
  3. Check "Filter has default value"
  4. Leave the default value empty so the validation error "Value is required" appears
  5. Verify the sync (refresh) icon stays aligned with the select field, not centered with field + error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 9, 2026

Code Review Agent Run #2a4c32

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: f70ccaa..f70ccaa
    • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Feb 9, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

The PR changes the DefaultValueContainer layout and adds top margin to the sync icon so that the refresh icon remains visually aligned with the input field even when a validation error message appears. The diagram shows the render path (layout anchoring) and the user-triggered refresh flow.

sequenceDiagram
    participant User
    participant FiltersConfigForm
    participant DefaultValueContainer
    participant DataService

    User->>FiltersConfigForm: Open Filters → shows "Default Value" row
    FiltersConfigForm->>DefaultValueContainer: Render with align-items:flex-start + icon margin-top
    DefaultValueContainer-->>FiltersConfigForm: Icon anchored at input level (error flows below)
    User->>FiltersConfigForm: Click sync (refresh) icon
    FiltersConfigForm->>DataService: refreshHandler(true) → fetch default values
    DataService-->>FiltersConfigForm: Return default values
    FiltersConfigForm-->>User: Update Default Value field (icon stays aligned)
Loading

Generated by CodeAnt AI

@EnxDev EnxDev force-pushed the enxdev/fix/filter-select-refresh-icon branch from f70ccaa to 7c3510e Compare February 9, 2026 12:25
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 9, 2026

Code Review Agent Run #4f81d4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 7c3510e..7c3510e
    • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@EnxDev EnxDev requested a review from geido February 10, 2026 16:06
@sadpandajoe sadpandajoe added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Feb 10, 2026
@github-actions github-actions bot added 🎪 7c3510e 🚦 building Environment 7c3510e status: building 🎪 7c3510e 📅 2026-02-10T22-19 Environment 7c3510e created at 2026-02-10T22-19 🎪 7c3510e 🤡 sadpandajoe Environment 7c3510e requested by sadpandajoe 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Feb 10, 2026
@github-actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for 7c3510e

@github-actions github-actions bot added 🎪 7c3510e 🚦 deploying Environment 7c3510e status: deploying 🎪 7c3510e 🚦 running Environment 7c3510e status: running 🎪 🎯 7c3510e Active environment pointer - 7c3510e is receiving traffic 🎪 7c3510e 📅 2026-02-10T22-20 Environment 7c3510e created at 2026-02-10T22-20 🎪 7c3510e 🌐 52.41.73.168:8080 Environment 7c3510e URL: http://52.41.73.168:8080 (click to visit) and removed 🎪 7c3510e 🚦 building Environment 7c3510e status: building 🎪 7c3510e 🚦 deploying Environment 7c3510e status: deploying 🎪 7c3510e 🚦 running Environment 7c3510e status: running 🎪 🎯 7c3510e Active environment pointer - 7c3510e is receiving traffic 🎪 7c3510e 📅 2026-02-10T22-19 Environment 7c3510e created at 2026-02-10T22-19 labels Feb 10, 2026
@github-actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for 7c3510e

Environment: http://52.41.73.168:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

Copy link
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msyavuz msyavuz added the hold:testing! On hold for testing label Feb 11, 2026
@EnxDev EnxDev removed the hold:testing! On hold for testing label Feb 11, 2026
@EnxDev EnxDev removed 🎪 ⌛ 48h Environment expires after 48 hours (default) 🎪 7c3510e 🤡 sadpandajoe Environment 7c3510e requested by sadpandajoe 🎪 7c3510e 🚦 running Environment 7c3510e status: running 🎪 7c3510e 📅 2026-02-10T22-20 Environment 7c3510e created at 2026-02-10T22-20 🎪 7c3510e 🌐 52.41.73.168:8080 Environment 7c3510e URL: http://52.41.73.168:8080 (click to visit) labels Feb 11, 2026
@EnxDev EnxDev merged commit b012b63 into master Feb 11, 2026
100 of 102 checks passed
@EnxDev EnxDev deleted the enxdev/fix/filter-select-refresh-icon branch February 11, 2026 20:26
sadpandajoe pushed a commit that referenced this pull request Feb 26, 2026
sadpandajoe pushed a commit that referenced this pull request Feb 27, 2026
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Feb 28, 2026
sadpandajoe pushed a commit that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard:native-filters Related to the native filters of the Dashboard size/XS v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants