fix(dashboard): handle favorite fetch for deleted dashboards

superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx

@@ -42,7 +42,11 @@ export const FaveStar = ({
 }: FaveStarProps) => {
   const theme = useTheme();
   useEffect(() => {
-    fetchFaveStar?.(itemId);
+    // Only attempt to fetch favorite status if itemId is valid
+    // This prevents unnecessary API calls for deleted or invalid items
+    if (itemId && fetchFaveStar) {
+      fetchFaveStar(itemId);
+    }
   }, [fetchFaveStar, itemId]);
 
   const onClick = useCallback(

superset-frontend/src/dashboard/actions/dashboardState.js

@@ -113,15 +113,29 @@ export function fetchFaveStar(id) {
       .then(({ json }) => {
         dispatch(toggleFaveStar(!!json?.result?.[0]?.value));
       })
-      .catch(() =>
+      .catch(async error => {
+        const errorObject = await getClientErrorObject(error);
+
+        // HTTP 404: Dashboard no longer exists (expected case after deletion)
+        // This is a normal scenario when navigating after a dashboard has been deleted.
+        // Skipping error toast to prevent user-facing errors for expected behavior.
+        if (errorObject.status === 404) {
+          logging.debug(
+            `Favorite status fetch returned 404 for dashboard ID ${id}. ` +
+            `Dashboard may have been deleted. Skipping error notification.`
+          );
+          return;
+        }
+
+        // All other errors are unexpected and should be reported to the user
         dispatch(
           addDangerToast(
             t(
               'There was an issue fetching the favorite status of this dashboard.',
             ),
           ),
-        ),
-      );
+        );
+      });
   };
 }
 

superset-frontend/src/dashboard/actions/dashboardState.test.js

@@ -24,6 +24,8 @@ import {
   SAVE_DASHBOARD_STARTED,
   saveDashboardRequest,
   SET_OVERRIDE_CONFIRM,
+  fetchFaveStar,
+  TOGGLE_FAVE_STAR,
 } from 'src/dashboard/actions/dashboardState';
 import { UPDATE_COMPONENTS_PARENTS_LIST } from 'src/dashboard/actions/dashboardLayout';
 import {
@@ -234,4 +236,61 @@ describe('dashboardState actions', () => {
       );
     });
   });
+
+  // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
+  describe('fetchFaveStar', () => {
+    test('dispatches TOGGLE_FAVE_STAR on successful fetch', async () => {
+      const dashboardId = 123;
+      const dispatch = sinon.stub();
+
+      getStub.restore();
+      getStub = sinon.stub(SupersetClient, 'get').resolves({
+        json: {
+          result: [{ id: dashboardId, value: true }],
+        },
+      });
+
+      const thunk = fetchFaveStar(dashboardId);
+      await thunk(dispatch);
+
+      await waitFor(() => expect(dispatch.callCount).toBe(1));
+      expect(dispatch.getCall(0).args[0].type).toBe(TOGGLE_FAVE_STAR);
+      expect(dispatch.getCall(0).args[0].isStarred).toBe(true);
+    });
+
+    test('does not dispatch error toast on 404 response', async () => {
+      const dashboardId = 999;
+      const dispatch = sinon.stub();
+
+      getStub.restore();
+      const error404 = new Error('Not found');
+      error404.status = 404;
+      getStub = sinon.stub(SupersetClient, 'get').rejects(error404);
+
+      const thunk = fetchFaveStar(dashboardId);
+      await thunk(dispatch);
+
+      // Should not dispatch any action (no toast, no toggle)
+      expect(dispatch.callCount).toBe(0);
+    });
+
+    test('dispatches error toast on non-404 errors', async () => {
+      const dashboardId = 123;
+      const dispatch = sinon.stub();
+
+      getStub.restore();
+      const error500 = new Error('Internal server error');
+      error500.status = 500;
+      getStub = sinon.stub(SupersetClient, 'get').rejects(error500);
+
+      const thunk = fetchFaveStar(dashboardId);
+      await thunk(dispatch);
+
+      await waitFor(() => expect(dispatch.callCount).toBe(1));
+      // Verify error toast action was dispatched (ADD_TOAST with danger type)
+      const dispatchedAction = dispatch.getCall(0).args[0];
+      expect(dispatchedAction.type).toBe('ADD_TOAST');
+      expect(dispatchedAction.payload.toastType).toBe('danger');
+    });
+  });
 });

superset-frontend/src/dashboard/components/Header/index.jsx

@@ -592,7 +592,12 @@ const Header = () => {
   const faveStarProps = useMemo(
     () => ({
       itemId: dashboardInfo.id,
-      fetchFaveStar: boundActionCreators.fetchFaveStar,
+      // Only fetch favorite status for valid, existing dashboards
+      // Skip fetch entirely if dashboard ID is falsy to prevent
+      // 404 errors when navigating after dashboard deletion
+      fetchFaveStar: dashboardInfo.id
+        ? boundActionCreators.fetchFaveStar
+        : undefined,
       saveFaveStar: boundActionCreators.saveFaveStar,
       isStarred,
       showTooltip: true,