fix(Multilayer): preserve dashboard context for embedded#37495
Merged
fix(Multilayer): preserve dashboard context for embedded#37495
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
geido
approved these changes
Jan 28, 2026
Contributor
Code Review Agent Run #e1f1bbActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Member
sadpandajoe
pushed a commit
that referenced
this pull request
Jan 29, 2026
LevisNgigi
pushed a commit
to LevisNgigi/superset
that referenced
this pull request
Feb 4, 2026
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SUMMARY
Fixes deck.gl Multiple Layers charts failing to load in embedded mode with datasource permission errors. The issue occurs because child layer requests don't include the dashboard
context (dashboardId) in their form data, causing the security check to fail even though the guest user has access to the dashboard.
The fix ensures that when deck.gl Multiple Layers loads child slices via separate API calls, it preserves the dashboard context from the parent chart, allowing the backend to properly
validate guest user permissions.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
- can read on Dashboard
- can explore on Superset
- can explore_json on Superset
- can dashboard on Superset
- can read on CurrentUserRestApi
- Do NOT grant datasource-specific permissions
ADDITIONAL INFORMATION