fix: rename 'Subtotal' to 'Subvalue' in pivot tables#37458
fix: rename 'Subtotal' to 'Subvalue' in pivot tables#37458costajohnt wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
i18n
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #6b3610
Actionable Suggestions - 4
-
superset/translations/zh_TW/LC_MESSAGES/messages.po - 1
- Missing translation for Subvalue · Line 10512-10512
-
superset/translations/en/LC_MESSAGES/messages.po - 1
- Incorrect subtotal translation · Line 9686-9686
-
superset/translations/it/LC_MESSAGES/messages.po - 1
- Missing Italian translation for Subvalue · Line 10467-10467
-
superset/translations/uk/LC_MESSAGES/messages.po - 1
- Incorrect translation for subtotal · Line 10558-10559
Additional Suggestions - 1
-
superset/translations/pt/LC_MESSAGES/messages.po - 1
-
Missing Portuguese translation for pivot table subtotal · Line 10599-10599The msgid was correctly updated from "Subtotal" to "Subvalue" to match the code's translation key, but the msgstr remains empty. This will cause Portuguese users to see the untranslated "Subvalue" instead of "Subtotal" in pivot table subtotals. Based on translations in Spanish ("Subtotal") and Brazilian Portuguese ("Subtotal"), "Subtotal" is the appropriate Portuguese term here.
Code suggestion
@@ -10600,1 +10600,1 @@ - msgstr "" + msgstr "Subtotal"
-
Review Details
-
Files reviewed - 25 · Commit Range:
3f6c695..3f6c695- superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
- superset/charts/client_processing.py
- superset/translations/ar/LC_MESSAGES/messages.po
- superset/translations/ca/LC_MESSAGES/messages.po
- superset/translations/de/LC_MESSAGES/messages.po
- superset/translations/en/LC_MESSAGES/messages.po
- superset/translations/es/LC_MESSAGES/messages.po
- superset/translations/fa/LC_MESSAGES/messages.po
- superset/translations/fr/LC_MESSAGES/messages.po
- superset/translations/it/LC_MESSAGES/messages.po
- superset/translations/ja/LC_MESSAGES/messages.po
- superset/translations/ko/LC_MESSAGES/messages.po
- superset/translations/messages.pot
- superset/translations/nl/LC_MESSAGES/messages.po
- superset/translations/pl/LC_MESSAGES/messages.po
- superset/translations/pt/LC_MESSAGES/messages.po
- superset/translations/pt_BR/LC_MESSAGES/messages.po
- superset/translations/ru/LC_MESSAGES/messages.po
- superset/translations/sk/LC_MESSAGES/messages.po
- superset/translations/sl/LC_MESSAGES/messages.po
- superset/translations/tr/LC_MESSAGES/messages.po
- superset/translations/uk/LC_MESSAGES/messages.po
- superset/translations/zh/LC_MESSAGES/messages.po
- superset/translations/zh_TW/LC_MESSAGES/messages.po
- tests/unit_tests/charts/test_client_processing.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| msgstr "氣泡尺寸" | ||
|
|
||
| msgid "Subtotal" | ||
| msgid "Subvalue" |
There was a problem hiding this comment.
The msgid has been changed from 'Subtotal' to 'Subvalue', but the msgstr remains empty. This will display 'Subvalue' to zh_TW users instead of a translated string. Please provide an appropriate translation.
Code Review Run #6b3610
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
|
|
||
| msgid "Subtotal" | ||
| msgid "Subvalue" | ||
| msgstr "" |
There was a problem hiding this comment.
The msgid was updated to "Subvalue", but the msgstr remains empty, causing pivot table subtotals to display as "Subvalue" instead of the correct "Subtotal". This affects user-facing labels in superset/charts/client_processing.py and superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx.
Code suggestion
Check the AI-generated fix before applying
| msgstr "" | |
| msgstr "Subtotal" |
Code Review Run #6b3610
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
| msgstr "Grandezza della bolla" | ||
|
|
||
| msgid "Subtotal" | ||
| msgid "Subvalue" |
There was a problem hiding this comment.
The msgid has been updated from 'Subtotal' to 'Subvalue' to match the string used in the code (e.g., in superset/charts/client_processing.py), but the msgstr remains empty. This could result in untranslated 'Subvalue' appearing in the UI for Italian users. Please add the appropriate Italian translation.
Code Review Run #6b3610
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
| msgid "Subvalue" | ||
| msgstr "Суттєвий" |
There was a problem hiding this comment.
The msgid changed from "Subtotal" to "Subvalue", but the msgstr remained "Суттєвий" (meaning "significant"). In pivot table context, "Subvalue" refers to subtotal labels, which should be "підсумок" in Ukrainian, as confirmed by standard translations and other languages like French ("Sous-total").
Code suggestion
Check the AI-generated fix before applying
| msgid "Subvalue" | |
| msgstr "Суттєвий" | |
| msgid "Subvalue" | |
| msgstr "підсумок" |
Code Review Run #6b3610
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37458 +/- ##
===========================================
+ Coverage 0 66.21% +66.21%
===========================================
Files 0 647 +647
Lines 0 49540 +49540
Branches 0 5568 +5568
===========================================
+ Hits 0 32803 +32803
- Misses 0 15435 +15435
- Partials 0 1302 +1302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
costajohnt
force-pushed
the
fix/rename-subtotal-subvalue
branch
from
3f6c695 to
6919234
Compare
There was a problem hiding this comment.
Code Review Agent Run #cc19f2
Actionable Suggestions - 1
-
superset/translations/zh/LC_MESSAGES/messages.po - 1
- Missing Translation · Line 10498-10498
Additional Suggestions - 1
-
superset/translations/nl/LC_MESSAGES/messages.po - 1
-
Incorrect Dutch Translation · Line 10542-10542The msgid changed from "Subtotal" to "Subvalue", but the Dutch translation remained "Subtotaal" (subtotal). Since "Subvalue" means a subordinate value, it should be translated as "Subwaarde" in Dutch.
Code suggestion
@@ -10543,1 +10543,1 @@ -msgstr "Subtotaal" +msgstr "Subwaarde"
-
Review Details
-
Files reviewed - 25 · Commit Range:
6919234..6919234- superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx
- superset/charts/client_processing.py
- superset/translations/ar/LC_MESSAGES/messages.po
- superset/translations/ca/LC_MESSAGES/messages.po
- superset/translations/de/LC_MESSAGES/messages.po
- superset/translations/en/LC_MESSAGES/messages.po
- superset/translations/es/LC_MESSAGES/messages.po
- superset/translations/fa/LC_MESSAGES/messages.po
- superset/translations/fr/LC_MESSAGES/messages.po
- superset/translations/it/LC_MESSAGES/messages.po
- superset/translations/ja/LC_MESSAGES/messages.po
- superset/translations/ko/LC_MESSAGES/messages.po
- superset/translations/messages.pot
- superset/translations/nl/LC_MESSAGES/messages.po
- superset/translations/pl/LC_MESSAGES/messages.po
- superset/translations/pt/LC_MESSAGES/messages.po
- superset/translations/pt_BR/LC_MESSAGES/messages.po
- superset/translations/ru/LC_MESSAGES/messages.po
- superset/translations/sk/LC_MESSAGES/messages.po
- superset/translations/sl/LC_MESSAGES/messages.po
- superset/translations/tr/LC_MESSAGES/messages.po
- superset/translations/uk/LC_MESSAGES/messages.po
- superset/translations/zh/LC_MESSAGES/messages.po
- superset/translations/zh_TW/LC_MESSAGES/messages.po
- tests/unit_tests/charts/test_client_processing.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| msgstr "气泡尺寸" | ||
|
|
||
| msgid "Subtotal" | ||
| msgid "Subvalue" |
There was a problem hiding this comment.
The msgid change from 'Subtotal' to 'Subvalue' aligns with the pot file and code usage in client_processing.py, but the msgstr remains empty. This will display untranslated 'Subvalue' to Chinese users, unlike other languages (e.g., French uses 'Sous-total'). A translation is needed to maintain consistency.
Code Review Run #cc19f2
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Renames the "Subtotal" label to "Subvalue" in pivot table displays. The term "Subtotal" implies summation, which is misleading when using other aggregation functions like AVG, MAX, or MIN. Updates: - Frontend TableRenderers.jsx (2 locations) - Backend client_processing.py (2 locations) - Translation template and 21 language files - Test assertions Closes apache#35089 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
costajohnt
force-pushed
the
fix/rename-subtotal-subvalue
branch
from
6919234 to
adccf26
Compare
1 participant
Summary
Renames the "Subtotal" label to "Subvalue" in pivot table displays.
The term "Subtotal" implies summation, which is misleading when using other aggregation functions like AVG, MAX, or MIN. "Subvalue" is more semantically accurate for intermediate aggregated values.
Changes
TableRenderers.jsx- 2 label changesclient_processing.py- 2 code changesmessages.pottemplate and 21 language filestest_client_processing.pyTest plan
Closes #35089
🤖 Generated with Claude Code