fix(explore): remove extra spacing when Advanced Analytics section is hidden

[VanessaGiannoni]

SUMMARY

Fixed incorrect spacing in the control panel when the Advanced Analytics section is hidden for non-temporal x-axis charts.

Root cause: The displayTimeRelatedControls visibility function correctly determined when to hide Advanced Analytics for non-temporal x-axis, but the section rendering used visibility: hidden instead of display: none, leaving empty space in the UI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER

BEFORE

TESTING INSTRUCTIONS

1. Create or edit a chart with a non-temporal x-axis (e.g., categorical data)
2. Open the chart in Explore view
3. Verify the Advanced Analytics section is not visible in the control panel
4. Confirm there is no extra spacing gap where the section would normally appear
5. Switch to a chart with a temporal x-axis and verify Advanced Analytics section appears normally
6. Run the existing tests: npm run test -- --testPathPatterns="ControlPanelsContainer.test.tsx"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #07374b

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 302efec..302efec

  • superset-frontend/src/explore/components/ControlPanelsContainer.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	302efec
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6977e4a405c77e0008af9193
😎 Deploy Preview	https://deploy-preview-37456--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[msyavuz]

Is before after screenshots backwards?

[VanessaGiannoni]

Is before after screenshots backwards?

Ooops my bad, let me fix the labeling 😅