Skip to content
Merged
Show file tree
Hide file tree
Changes from 55 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
19151d1
fix: fixed Add Metrics to Tree Chart (#29158)
SBIN2010 Oct 22, 2024
35aaeb6
fix: clear modal after CSS templates is added
SBIN2010 Oct 22, 2024
db3afda
Revert "fix: clear modal after CSS templates is added"
SBIN2010 Oct 23, 2024
9eea2e6
fix: tree metrics exclude validator
SBIN2010 Nov 25, 2024
3930c95
Merge branch 'apache:master' into master
SBIN2010 Mar 11, 2025
b355212
Merge branch 'apache:master' into master
SBIN2010 Mar 18, 2025
7200d6c
Merge branch 'apache:master' into master
SBIN2010 Mar 20, 2025
3049a3d
Merge branch 'apache:master' into master
SBIN2010 Mar 25, 2025
247aef8
Merge branch 'apache:master' into master
SBIN2010 Apr 2, 2025
b4678ec
Merge branch 'apache:master' into master
SBIN2010 Apr 4, 2025
0ae844d
Merge branch 'apache:master' into master
SBIN2010 Jul 1, 2025
49fc529
Merge branch 'apache:master' into master
SBIN2010 Jul 10, 2025
601dde2
fix: revert #30679
SBIN2010 Mar 25, 2025
66823a5
Merge branch 'apache:master' into master
SBIN2010 Jul 12, 2025
4f59629
Merge branch 'apache:master' into master
SBIN2010 Jul 16, 2025
a7ce4e9
Merge branch 'apache:master' into master
SBIN2010 Jul 20, 2025
1bf4fdd
fix
SBIN2010 Jul 20, 2025
1241867
Merge branch 'apache:master' into master
SBIN2010 Jul 31, 2025
045cf6b
Merge branch 'apache:master' into master
SBIN2010 Aug 2, 2025
acdba8a
Merge branch 'apache:master' into master
SBIN2010 Aug 10, 2025
4fb89c2
Merge branch 'apache:master' into master
SBIN2010 Aug 15, 2025
f47d28b
Merge branch 'apache:master' into master
SBIN2010 Aug 18, 2025
3bdf337
Merge branch 'apache:master' into master
SBIN2010 Aug 19, 2025
780a5d6
Merge branch 'apache:master' into master
SBIN2010 Aug 24, 2025
3c339df
Merge branch 'apache:master' into master
SBIN2010 Aug 25, 2025
798b7a6
Merge branch 'apache:master' into master
SBIN2010 Aug 30, 2025
2db564e
Merge branch 'apache:master' into master
SBIN2010 Sep 3, 2025
a58cfad
Merge branch 'apache:master' into master
SBIN2010 Sep 5, 2025
9ea0d2f
Merge branch 'apache:master' into master
SBIN2010 Sep 8, 2025
c6bbf53
Merge branch 'apache:master' into master
SBIN2010 Sep 9, 2025
5214e7a
Merge branch 'apache:master' into master
SBIN2010 Sep 15, 2025
d98105c
Merge branch 'apache:master' into master
SBIN2010 Sep 17, 2025
30b1576
Merge branch 'apache:master' into master
SBIN2010 Sep 19, 2025
4aaa27c
Merge branch 'apache:master' into master
SBIN2010 Sep 23, 2025
25c1987
Merge branch 'apache:master' into master
SBIN2010 Sep 24, 2025
c3854cb
Merge branch 'apache:master' into master
SBIN2010 Oct 1, 2025
e1c4909
Merge branch 'apache:master' into master
SBIN2010 Oct 1, 2025
c60bda8
Merge branch 'apache:master' into master
SBIN2010 Oct 2, 2025
964307e
Merge branch 'apache:master' into master
SBIN2010 Oct 14, 2025
df97cb7
Merge branch 'apache:master' into master
SBIN2010 Oct 22, 2025
6ef82fa
Merge branch 'apache:master' into master
SBIN2010 Oct 27, 2025
d0ae96c
Merge branch 'apache:master' into master
SBIN2010 Oct 29, 2025
725039c
Merge branch 'apache:master' into master
SBIN2010 Oct 29, 2025
727c59f
Merge branch 'apache:master' into master
SBIN2010 Nov 2, 2025
eeb04da
Merge branch 'apache:master' into master
SBIN2010 Nov 7, 2025
ca12644
Merge branch 'apache:master' into master
SBIN2010 Nov 10, 2025
45c1a1a
Merge branch 'apache:master' into master
SBIN2010 Nov 13, 2025
44708bf
Merge branch 'apache:master' into master
SBIN2010 Nov 14, 2025
59f2832
Merge branch 'apache:master' into master
SBIN2010 Nov 29, 2025
4cf50b1
Merge branch 'apache:master' into master
SBIN2010 Dec 18, 2025
e34d80e
Merge branch 'apache:master' into master
SBIN2010 Dec 22, 2025
a48fb9c
Merge branch 'apache:master' into master
SBIN2010 Jan 10, 2026
5100172
Merge branch 'apache:master' into master
SBIN2010 Jan 12, 2026
0bd47e9
Merge branch 'apache:master' into master
SBIN2010 Jan 15, 2026
354dee8
fix: tokenSeparators is overridden by default
SBIN2010 Jan 26, 2026
5a2d7c6
fix: add docs for tokenSeparators and default path
SBIN2010 Jan 26, 2026
4b90d9e
fix: add test
SBIN2010 Jan 27, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ export type ControlFormItemSpec<T extends ControlType = ControlType> = {
creatable?: boolean;
minWidth?: number | string;
validators?: ControlFormValueValidator<string>[];
tokenSeparators?: string[];
}
: T extends 'RadioButtonControl'
? {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const d3NumberFormat: ControlFormItemSpec<'Select'> = {
creatable: true,
minWidth: '14em',
debounceDelay: 500,
tokenSeparators: ['\r\n', '\n', '\t', ';'],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inappropriate tokenSeparators for single select

The tokenSeparators property enables pasting multi-line text into this single-value select control, which can result in invalid D3 format strings containing newlines. Since the control expects a single string value and tokenSeparators are intended for multi-select scenarios, this should be removed to avoid potential incorrect input.

Code suggestion
Check the AI-generated fix before applying
 -    minWidth: '14em',
 -    debounceDelay: 500,
 -  tokenSeparators: ['\\r\\n', '\\n', '\\t', ';'],
 -  };
 +    minWidth: '14em',
 +    debounceDelay: 500,
 +  };

Code Review Run #5daef7


Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

};

const d3TimeFormat: ControlFormItemSpec<'Select'> = {
Expand Down
Loading