Conversation
|
Bito Automatic Review Skipped - Files Excluded |
|
CI is failing with widespread test failures. d3-format 3.x is a major version bump from 1.4.5, with API changes and ESM-only distribution that break many components across the codebase. |
9ec1dd8 to
e92fbf0
Compare
|
Rebased on master and fixed compatibility issues with d3-format v3: Changes made:
All 74 number-format tests pass. |
Code Review Agent Run #b879adActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps [d3-format](https://github.com/d3/d3-format) from 1.4.5 to 3.1.2. - [Release notes](https://github.com/d3/d3-format/releases) - [Commits](d3/d3-format@v1.4.5...v3.1.2) --- updated-dependencies: - dependency-name: d3-format dependency-version: 3.1.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Add d3-format to Jest transformIgnorePatterns (ESM-only package) - Configure minus sign in DEFAULT_D3_FORMAT locale to use ASCII hyphen for backward compatibility (d3-format v3 defaults to Unicode minus) - Update formatters to use locale-aware formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
e92fbf0 to
dc1a41f
Compare
Code Review Agent Run #1d86e4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Add explicit tests that verify negative numbers use ASCII hyphen-minus (U+002D, char code 45) instead of Unicode minus sign (U+2212, char code 8722). This documents the backward compatibility requirement after the d3-format v3 upgrade, which changed the default minus sign to Unicode. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Bito Automatic Review Skipped – PR Already Merged |
Bumps d3-format from 1.4.5 to 3.1.2.
Release notes
Sourced from d3-format's releases.
Commits
ebdc2d53.1.2db99ee9fix #149; avoid ES2020 syntax; enforce ES2019ee1044f3.1.1932d0c1fix zero precision (#147)17585dbFix for issue 134 (#135)a13ebb9upgrades (#148)f3cb310restructure README (#141)08806c63.1.0190a2c2upgrade dependenciesb8cdc5efix #116; document type c as character dataMaintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for d3-format since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)