Skip to content

chore(deps): bump d3-format from 1.4.5 to 3.1.2 in /superset-frontend/packages/superset-ui-core#37442

Merged
rusackas merged 4 commits intomasterfrom
dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/d3-format-3.1.2
Feb 7, 2026
Merged

chore(deps): bump d3-format from 1.4.5 to 3.1.2 in /superset-frontend/packages/superset-ui-core#37442
rusackas merged 4 commits intomasterfrom
dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/d3-format-3.1.2

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 26, 2026

Bumps d3-format from 1.4.5 to 3.1.2.

Release notes

Sourced from d3-format's releases.

v3.1.2

  • Avoid use of optional chaining to retain ES2019 compatibility. #149

v3.1.1

  • Fix handling of parens with formatPrefix. #134 #135 #142 Thanks, @​GlenKelley!
  • Fix precisionFixed, precisionRound, and precisionPrefix to return NaN when step is zero. #147
  • Fix the s format to not sometimes apply an erroneous suffix to NaN or ±Infinity. #147
  • The r format now formats zero as 0 instead of 0.0. #147
  • Upgrade ESLint, Vitest, etc.

v3.1.0

  • Export local definitions. #118
  • Update local definitions. #120
  • Fix documentation for the type c character data format. #116
  • Upgrade dependencies.

v3.0.1

  • Update dependencies.
  • Make build reproducible.

v3.0.0

  • Adopt type: module.

This package now requires Node.js 12 or higher. For more, please read Sindre Sorhus’s FAQ.

v2.0.0

  • Change the default minus sign to the minus sign (−) instead of hyphen-minus (-). #62

This release adopts ES2015 language features such as for-of and drops support for older browsers, including IE. If you need to support pre-ES2015 environments, you should stick with d3-format 1.x or use a transpiler.

Commits
Maintainer changes

This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for d3-format since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Jan 26, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 26, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@rusackas
Copy link
Member

CI is failing with widespread test failures. d3-format 3.x is a major version bump from 1.4.5, with API changes and ESM-only distribution that break many components across the codebase.

@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/d3-format-3.1.2 branch from 9ec1dd8 to e92fbf0 Compare February 6, 2026 06:27
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Feb 6, 2026
@rusackas
Copy link
Member

rusackas commented Feb 6, 2026

Rebased on master and fixed compatibility issues with d3-format v3:

Changes made:

  1. Added d3-format to Jest's transformIgnorePatterns - d3-format v3 is ESM-only
  2. Added minus: '-' to DEFAULT_D3_FORMAT locale config - d3-format v3 uses Unicode minus sign (−) by default, which would break backward compatibility
  3. Updated createSmartNumberFormatter and createSiAtMostNDigitFormatter to use locale-aware formatting

All 74 number-format tests pass.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 6, 2026

Code Review Agent Run #b879ad

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: 6af9d1c..e92fbf0
    • superset-frontend/jest.config.js
    • superset-frontend/packages/superset-ui-core/src/number-format/D3FormatConfig.ts
    • superset-frontend/packages/superset-ui-core/src/number-format/factories/createSiAtMostNDigitFormatter.ts
    • superset-frontend/packages/superset-ui-core/src/number-format/factories/createSmartNumberFormatter.ts
  • Files skipped - 2
    • superset-frontend/package-lock.json - Reason: Filter setting
    • superset-frontend/packages/superset-ui-core/package.json - Reason: Filter setting
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas
Copy link
Member

rusackas commented Feb 6, 2026

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2026

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 3 commits February 6, 2026 15:56
Bumps [d3-format](https://github.com/d3/d3-format) from 1.4.5 to 3.1.2.
- [Release notes](https://github.com/d3/d3-format/releases)
- [Commits](d3/d3-format@v1.4.5...v3.1.2)

---
updated-dependencies:
- dependency-name: d3-format
  dependency-version: 3.1.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Add d3-format to Jest transformIgnorePatterns (ESM-only package)
- Configure minus sign in DEFAULT_D3_FORMAT locale to use ASCII hyphen
  for backward compatibility (d3-format v3 defaults to Unicode minus)
- Update formatters to use locale-aware formatting

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/d3-format-3.1.2 branch from e92fbf0 to dc1a41f Compare February 7, 2026 00:34
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 7, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 7, 2026

Code Review Agent Run #1d86e4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 5 · Commit Range: 16ee1c2..dc1a41f
    • superset-frontend/jest.config.js
    • superset-frontend/packages/superset-ui-core/src/number-format/D3FormatConfig.ts
    • superset-frontend/packages/superset-ui-core/src/number-format/factories/createD3NumberFormatter.ts
    • superset-frontend/packages/superset-ui-core/src/number-format/factories/createSiAtMostNDigitFormatter.ts
    • superset-frontend/packages/superset-ui-core/src/number-format/factories/createSmartNumberFormatter.ts
  • Files skipped - 2
    • superset-frontend/package-lock.json - Reason: Filter setting
    • superset-frontend/packages/superset-ui-core/package.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Add explicit tests that verify negative numbers use ASCII hyphen-minus
(U+002D, char code 45) instead of Unicode minus sign (U+2212, char code
8722). This documents the backward compatibility requirement after the
d3-format v3 upgrade, which changed the default minus sign to Unicode.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rusackas rusackas merged commit 76a27d5 into master Feb 7, 2026
68 checks passed
@rusackas rusackas deleted the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/d3-format-3.1.2 branch February 7, 2026 07:42
@bito-code-review
Copy link
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant