Skip to content

fix(listview): prevent table column layout shift on content change #37299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
massucattoj wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(listview): prevent table column layout shift on content change #37299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80056c1
fix(listview): prevent table column layout shift on content change
massucattoj Jan 21, 2026
1fd7c6b
fix(listview): prevent table column layout shift dashboard and charts
massucattoj Jan 21, 2026
7269e68
fix(table)/ensure-icon-start-appears-correctly
massucattoj Jan 23, 2026
66a1e9d
fix(tables): change title to a fix width of 360px and return the othe…
massucattoj Feb 12, 2026
bef9828
fix(tables): change title to a fix width of 360px and return the othe…
massucattoj Feb 12, 2026
fae1cd6
fix(tables): change name from 3xl to xxxl
massucattoj Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {

import { SortOrder } from '../Table';

type TableSize = 'xs' | 'sm' | 'md' | 'lg' | 'xl' | 'xxl';
type TableSize = 'xs' | 'sm' | 'md' | 'lg' | 'xl' | 'xxl' | 'xxxl';

type RowWithId<T extends object> = Row<T> & { rowId: string };

Expand All @@ -47,6 +47,7 @@ const COLUMN_SIZE_MAP: Record<TableSize, number> = {
lg: 100,
xl: 150,
xxl: 200,
xxxl: 360,
};

type EnhancedColumnInstance<T extends object = any> = RTColumnInstance<T> &
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/src/pages/ChartList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ function ChartList(props: ChartListProps) {
Header: '',
id: 'id',
disableSortBy: true,
size: 'xs',
size: 'sm',
hidden: !userId,
},
{
Expand Down Expand Up @@ -372,6 +372,7 @@ function ChartList(props: ChartListProps) {
),
Header: t('Name'),
accessor: 'slice_name',
size: 'xxxl',
id: 'slice_name',
},
{
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/src/pages/DashboardList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ function DashboardList(props: DashboardListProps) {
Header: '',
id: 'id',
disableSortBy: true,
size: 'xs',
size: 'sm',
hidden: !user?.userId,
},
{
Expand Down Expand Up @@ -351,6 +351,7 @@ function DashboardList(props: DashboardListProps) {
),
Header: t('Name'),
accessor: 'dashboard_title',
size: 'xxxl',
id: 'dashboard_title',
},
{
Expand Down
12 changes: 4 additions & 8 deletions superset-frontend/src/pages/DatasetList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,10 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
const columns = useMemo(
() => [
{
Cell: ({
row: {
original: { kind },
},
}: any) => null,
accessor: 'kind_icon',
disableSortBy: true,
size: 'xs',
accessor: 'id',
id: 'id',
hidden: true,
disableSortBy: true,
},
{
Cell: ({
Expand Down Expand Up @@ -351,6 +346,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
},
Header: t('Name'),
accessor: 'table_name',
size: 'xxxl',
id: 'table_name',
},
{
Expand Down
Loading