Skip to content

fix(roles): allow Public role to read themes #37295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadpandajoe merged 1 commit into from
Jan 21, 2026
+2 −1
Merged

fix(roles): allow Public role to read themes #37295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,9 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods
("can_time_range", "Api"),
("can_query_form_data", "Api"),
("can_query", "Api"),
# CSS for dashboard styling
# CSS and themes for dashboard styling
("can_read", "CssTemplate"),
("can_read", "Theme"),
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test assertion for the Theme permission in the existing test_public_role_permissions method (e.g., assert ("can_read", "Theme") in public_perm_set). This would ensure the Theme permission is explicitly verified alongside CssTemplate and other styling-related permissions, providing better regression protection for the fix in issue #37294.

Copilot uses AI. Check for mistakes.
# Embedded dashboard support
("can_read", "EmbeddedDashboard"),
# Datasource metadata for chart rendering
Expand Down
Loading