fix(deckgl-contour): prevent WebGL freeze by clamping and auto-scaling cellSize by YousufFFFF · Pull Request #37244 · apache/superset

YousufFFFF · 2026-01-19T09:19:56Z

Summary

This PR prevents Deck.gl Contour charts from freezing or crashing the browser/WebGL when extremely small cellSize values are used.

It introduces safety guards that:

Clamp cellSize to a safe min/max range
Auto-scale cellSize when the estimated grid size becomes dangerously large
Prevents GPU buffer overflows and UI freezes
Keeps existing behavior for normal values

Problem

Very small cellSize values can generate millions of grid cells, which causes:

WebGL buffer allocation failures
UI freezes
Browser tab crashes
Console errors like:

Solution

We now:

Clamp cellSize between safe min/max bounds
Estimate the total grid cell count
Auto-scale cellSize if the grid becomes too large
Log a warning when auto-adjustment occurs

This keeps the chart responsive and prevents GPU crashes.

After

localhost_8088_explore__viz_type.deck_contour.datasource.3__table.-.Google.Chrome.2026-01-19.14-45-37.mp4

Behavior Changes

No change for valid cellSize values
Extremely small values are safely adjusted instead of crashing the app

Testing

Reproduced freeze/crash with very small cellSize
Verified UI no longer freezes
Verified chart renders correctly
Verified console errors are gone

codeant-ai-for-open-source · 2026-01-19T09:20:02Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-19T09:20:06Z

Code Review Agent Run #029ca1

Actionable Suggestions - 0

Additional Suggestions - 2

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts - 2
- Incorrect display name logic · Line 403-410
  
  The substring check entryName.includes(metricPart) can incorrectly skip adding the metric prefix when entryName contains the metric name as a substring (e.g., dimension "Sales Volume" with metric "Sales" would display as "Sales Volume" instead of "Sales, Sales Volume"). This changes observable chart display behavior. Always concatenate for reliable formatting.
  Code suggestion
  @@ -407,3 +407,1 @@ - displayName = entryName.includes(metricPart) - ? entryName - : `${metricPart}, ${entryName}`; + displayName = `${metricPart}, ${entryName}`;
- Incorrect display name logic · Line 476-483
  
  Same issue as Query A: the substring check can incorrectly skip the metric prefix, leading to malformed display names in charts with groupby. Revert to consistent concatenation.
  Code suggestion
  @@ -480,3 +480,1 @@ - displayName = entryName.includes(metricPart) - ? entryName - : `${metricPart}, ${entryName}`; + displayName = `${metricPart}, ${entryName}`;

Review Details

Files reviewed - 2 · Commit Range: 4d8b727..cf13edd
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
- superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-19T09:23:19Z

CodeAnt AI finished reviewing your PR.

netlify · 2026-01-19T09:23:25Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`cf13edd`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/696df740a04bf40008dc0b30
😎 Deploy Preview	https://deploy-preview-37244--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

YousufFFFF · 2026-01-19T10:16:56Z

Hi @DamianPendrak @rusackas
I’ve opened this PR to fix a Deck.gl Contour freeze/crash caused by extreme cellSize values by adding safety guards and auto-scaling.
Would really appreciate your review when you get a chance. Thanks!

bito-code-review · 2026-01-19T10:52:19Z

Code Review Agent Run #bfcdbf

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: cf13edd..4dde3ce
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-19T16:54:28Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

codeant-ai-for-open-source · 2026-01-19T16:56:57Z

CodeAnt AI Incremental review completed.

YousufFFFF · 2026-01-19T17:22:04Z

All CI checks are now passing
This PR is ready for review.
@DamianPendrak , would really appreciate your feedback when you have time. Thanks!

bito-code-review · 2026-01-19T17:56:48Z

Code Review Agent Run #87df25

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 4dde3ce..cc6a173
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

github-actions · 2026-01-20T09:13:20Z

🎪 Showtime is building environment on GHA for cc6a173

Copilot

Pull request overview

This PR adds safety guards to prevent WebGL freezes and crashes in Deck.gl Contour charts when extremely small cellSize values are used. The fix introduces validation, clamping, and auto-scaling logic to ensure grid cell counts remain within safe limits.

Changes:

Added cellSize validation with safe min/max bounds (10-5000)
Implemented auto-scaling when estimated grid cells exceed 1 million
Added warning logging when auto-adjustment occurs

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx

DamianPendrak

The tests would be great here. I requested the Copilot review - @YousufFFFF do you think there is something to improve from the suggestions?

YousufFFFF · 2026-01-20T13:57:08Z

Thanks @DamianPendrak ! I’ve reviewed the Copilot suggestions. I’ll incorporate the safety-related ones (explicit viewport dimension checks, clamping after auto-scaling, and clearer naming)

codeant-ai-for-open-source · 2026-01-20T14:45:44Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

YousufFFFF · 2026-01-20T14:46:52Z

I’ve applied the safety-related Copilot suggestions (explicit viewport checks, post-auto-scale clamping, and clearer naming).

codeant-ai-for-open-source · 2026-01-20T14:49:31Z

CodeAnt AI Incremental review completed.

bito-code-review · 2026-01-20T15:52:14Z

Code Review Agent Run #620d8f

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: cc6a173..cd1bbf7
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-22T05:32:13Z

Code Review Agent Run #015b81

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: cd1bbf7..182084e
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/getSafeCellSize.test.ts
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/getSafeCellSize.ts
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/index.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

YousufFFFF · 2026-01-22T11:50:48Z

Hey @DamianPendrak !
I have refactored the safety logic into a pure helper (getSafeCellSize) and added unit tests around it.
Would appreciate another look when you have time
Thanks!!

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/index.ts

bito-code-review · 2026-01-23T11:57:36Z

Code Review Agent Run #cf90a7

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 182084e..8687731
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/Contour.tsx
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/getSafeCellSize.test.ts
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/getSafeCellSize.ts
- superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/index.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

DamianPendrak

Thank you @YousufFFFF! LGTM

YousufFFFF · 2026-01-24T08:49:23Z

Thank you for the review, Damian! Much appreciated.
If any deck.gl–related issues come up, feel free to loop me in. Happy to help.

…g cellSize (#37244) (cherry picked from commit b09e60c)

…g cellSize (apache#37244)

YousufFFFF added 2 commits January 16, 2026 20:14

Fix duplicate metric labels in Mixed Timeseries legend

4d8b727

fix(deck.gl): prevent contour layer freeze for extreme cellSize

cf13edd

pull-request-size bot added the size/M label Jan 19, 2026

github-actions bot added the plugins label Jan 19, 2026

dosubot bot added the viz:charts:deck.gl Related to deck.gl charts label Jan 19, 2026

chore: revert unrelated MixedTimeseries change

4dde3ce

YousufFFFF added 3 commits January 19, 2026 10:56

chore: rerun CI

cc694b6

chore: retrigger CI

6e12b3b

chore: apply pre-commit formatting

cc6a173

DamianPendrak added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 20, 2026

Copilot started reviewing on behalf of DamianPendrak January 20, 2026 09:43 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

DamianPendrak reviewed Jan 20, 2026

View reviewed changes

fix(deckgl-contour): improve safety checks and clamping

cd1bbf7

github-actions bot added the 🎪 🔒 showtime-blocked label Jan 20, 2026

fix(deckGL Contour): add safe cell size guard and unit tests

d9f0a76

pull-request-size bot added size/L and removed size/M labels Jan 22, 2026

chore(deckgl-contour): add ASF license headers

182084e

DamianPendrak reviewed Jan 23, 2026

View reviewed changes

superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Contour/index.ts Outdated Show resolved Hide resolved

chore(deckgl-contour): explicitly export getSafeCellSize

8687731

DamianPendrak approved these changes Jan 24, 2026

View reviewed changes

rusackas merged commit b09e60c into apache:master Jan 24, 2026
68 checks passed

sadpandajoe pushed a commit that referenced this pull request Jan 26, 2026

fix(deckgl-contour): prevent WebGL freeze by clamping and auto-scalin…

3895db4

…g cellSize (#37244) (cherry picked from commit b09e60c)

sadpandajoe added v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch 🎪 🛑 showtime-trigger-stop Destroy ephemeral environment and clean up AWS resources labels Jan 26, 2026

aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Mar 5, 2026

fix(deckgl-contour): prevent WebGL freeze by clamping and auto-scalin…

0c7e348

…g cellSize (apache#37244)

Conversation

YousufFFFF commented Jan 19, 2026

Summary

Problem

Solution

After

Behavior Changes

Testing

Uh oh!

codeant-ai-for-open-source bot commented Jan 19, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #029ca1

Uh oh!

codeant-ai-for-open-source bot commented Jan 19, 2026

Uh oh!

netlify bot commented Jan 19, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

YousufFFFF commented Jan 19, 2026

Uh oh!

bito-code-review bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #bfcdbf

Uh oh!

codeant-ai-for-open-source bot commented Jan 19, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

codeant-ai-for-open-source bot commented Jan 19, 2026

Uh oh!

YousufFFFF commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bito-code-review bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #87df25

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DamianPendrak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YousufFFFF commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 20, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

YousufFFFF commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 20, 2026

Uh oh!

bito-code-review bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #620d8f

Uh oh!

bito-code-review bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #015b81

Uh oh!

YousufFFFF commented Jan 22, 2026

Uh oh!

Uh oh!

bito-code-review bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #cf90a7

Uh oh!

DamianPendrak left a comment

bito-code-review bot commented Jan 19, 2026 •

edited

Loading

bito-code-review bot commented Jan 19, 2026 •

edited

Loading

YousufFFFF commented Jan 19, 2026 •

edited

Loading

bito-code-review bot commented Jan 19, 2026 •

edited

Loading

DamianPendrak left a comment •

edited

Loading

YousufFFFF commented Jan 20, 2026 •

edited

Loading

YousufFFFF commented Jan 20, 2026 •

edited

Loading

bito-code-review bot commented Jan 20, 2026 •

edited

Loading

bito-code-review bot commented Jan 22, 2026 •

edited

Loading

bito-code-review bot commented Jan 23, 2026 •

edited

Loading