Skip to content

chore(deps): bump memoize-one from 5.2.1 to 6.0.0 in /superset-frontend/packages/superset-ui-demo #37151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 3 commits into from
Jan 27, 2026
Merged

chore(deps): bump memoize-one from 5.2.1 to 6.0.0 in /superset-frontend/packages/superset-ui-demo #37151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af0f31
chore(deps): bump memoize-one
dependabot[bot] Jan 23, 2026
1cfbe6f
chore(deps): update package-lock.json
rusackas Jan 27, 2026
5f9b6b7
fix(types): use concrete types for memoizeOne to fix TS2322 with memo…
rusackas Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion superset-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/packages/superset-ui-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"core-js": "3.40.0",
"gh-pages": "^6.3.0",
"jquery": "^4.0.0",
"memoize-one": "^5.2.1",
"memoize-one": "^6.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-loadable": "^5.5.0",
Expand Down
14 changes: 10 additions & 4 deletions .../packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/Table.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import memoizeOne from 'memoize-one';
import { SuperChart, VizType } from '@superset-ui/core';
import { DataRecord, SuperChart, VizType } from '@superset-ui/core';
import TableChartPlugin, {
TableChartProps,
} from '@superset-ui/plugin-chart-table';
Expand Down Expand Up @@ -77,7 +77,7 @@ export default {

new TableChartPlugin().configure({ key: VizType.Table }).register();

function expandArray<T>(input: T[], targetSize: number) {
function expandArray<T>(input: T[], targetSize: number): T[] {
if (!input || input.length === 0) {
throw new Error('Cannot expand an empty array');
}
Expand All @@ -90,8 +90,14 @@ function expandArray<T>(input: T[], targetSize: number) {

// memoize expanded array so to make sure we always return the same
// data when changing page sizes
const expandRecords = memoizeOne(expandArray);
const expandColumns = memoizeOne(expandArray);
const expandRecords = memoizeOne(
(input: DataRecord[], targetSize: number): DataRecord[] =>
expandArray(input, targetSize),
);
const expandColumns = memoizeOne(
(input: string[], targetSize: number): string[] =>
expandArray(input, targetSize),
);

/**
* Load sample data for testing
Expand Down
Loading