fix(Tabs): prevent infinite rerenders with nested tabs

[msyavuz]

SUMMARY

#35265 introduced a bug where refreshing a dashboard with nested tabs would cause infinite rerenders. This pr fixes that bug by introducing a lazy option to dashboard refresh action that doesn't update the global refresh time.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

tab-refresh-before.mp4

After:

tab-refresh-after.mp4

TESTING INSTRUCTIONS

1. Create a dashboard with nested tabs.
2. Refresh it using Refresh dashboard button on three-dot menu.

This should not cause infinite rerenders.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	45bb64d
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/696147da56df590008bfd387
😎 Deploy Preview	https://deploy-preview-37018--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

🎪 Showtime is building environment on GHA for 45bb64d

[github-actions]

🎪 Showtime deployed environment on GHA for 45bb64d

• Environment: http://18.236.111.15:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[bito-code-review]

Code Review Agent Run #998926

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: d983c0d..45bb64d

  • superset-frontend/src/dashboard/actions/dashboardState.js
  • superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.jsx
  • superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.test.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[github-actions]

🎪 Showtime is building environment on GHA for 92e5cac

[codeant-ai-for-open-source]

Sequence Diagram

The PR changes tab refresh behavior so that when a tab becomes visible after a dashboard-level refresh, the Tab component triggers a lazy chart refresh (isLazyLoad=true) and guards duplicate handling to avoid updating global refresh state — preventing infinite rerenders with nested tabs.

sequenceDiagram
    participant Dashboard UI
    participant Tab Component
    participant Redux Dispatcher
    participant Chart Refresher

    Dashboard UI->>Tab Component: Tab becomes visible (renderType=RENDER_TAB_CONTENT)
    Tab Component->>Tab Component: check lastRefreshTime > tabActivationTime && not handled
    Tab Component->>Redux Dispatcher: dispatch onRefresh(chartIds, force=true, interval=0, dashboardId, isLazyLoad=true)
    Redux Dispatcher->>Chart Refresher: refreshCharts(chartIds,...)
    Chart Refresher-->>Redux Dispatcher: refresh complete
    note right of Redux Dispatcher: because isLazyLoad=true, global ON_REFRESH and filters refresh are NOT dispatched

Loading

---

Generated by CodeAnt AI

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Potential filter staleness The PR also skips onFiltersRefresh() for lazy loads. Make sure this will not leave filter state inconsistent when nested tab charts are refreshed lazily — verify that filters remain correct and that UI doesn't show inconsistent data when onFiltersRefresh is suppressed. Reducer / side-effect changes Skipping the ON_REFRESH action and onFiltersRefresh() for lazy loads may prevent reducers or middleware from running logic previously tied to that action (for example, global refresh time updates, metrics, or other side effects). Audit reducers and middleware listening for ON_REFRESH or ON_FILTERS_REFRESH to ensure skipping them for lazy loads doesn't produce stale state or missed telemetry. Callsite compatibility The new isLazyLoad parameter changes the semantics of onRefresh. Consumers that need lazy refresh behavior must pass true; otherwise behavior remains unchanged due to the default. Verify all call sites (including extensions and presets) that trigger refreshes for nested tabs or lazy-loaded components are updated to pass the flag where appropriate. If any callers dispatch onRefresh indirectly (e.g., via wrapper actions), confirm they propagate the new parameter.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[github-actions]

🎪 Showtime deployed environment on GHA for 92e5cac

• Environment: http://34.209.227.96:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it