fix(dashboard): resolve dropdown popup positioning #36963

reynoldmorel · 2026-01-08T01:21:16Z

SUMMARY

When zooming in any page (150% to 200% zoom), the dropdown filter popup was positioning over the dropdown input creating a bad user experience when manipulating the dropdown component.

The fix simply aligns the dropdown popup always below the dropdown input.

This fix will affect all the places that are using this dropdown component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

The dropdown covers the input box, preventing any filtering or selection via typing. This breaks basic usability on smaller screens.

AFTER

short_video_after.mov

TESTING INSTRUCTIONS

Create or open a dashboard with a filter of type Value that has 100+ options.
Open the filter dropdown on a screen smaller than 1080p resolution or simulate by increasing browser zoom (e.g., 150%).
Observe how the dropdown overlaps the input box and becomes unresponsive to typing.
Try to test the most important places where these dropdowns are used.

ADDITIONAL INFORMATION

Has associated issue: Dashboard Filter dropdown input obscured on smaller screens views #34135
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codeant-ai-for-open-source · 2026-01-08T01:21:21Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

codeant-ai-for-open-source · 2026-01-08T01:23:31Z

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review Overrides Prop The new hard-coded prop `dropdownAlign={DROPDOWN_ALIGN_BOTTOM}` is set after spreading `...props`, which unconditionally overrides any `dropdownAlign` provided by callers. This prevents consumers from customizing alignment and may be surprising or break integrations that rely on a different alignment. Type / API mismatch The new `DROPDOWN_ALIGN_BOTTOM` object is likely intended for Ant Design / rc-trigger alignment APIs. The shape uses numeric values (0/1) for `overflow.adjustX`/`adjustY` which may not match the expected types (often booleans) or the library's AlignType. Confirm the runtime API accepts these values and add an explicit type to the constant to avoid subtle runtime behavior differences across environments.

codeant-ai-for-open-source · 2026-01-08T01:23:58Z

CodeAnt AI finished reviewing your PR.

netlify · 2026-01-08T01:24:27Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`3f38a44`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695f068f587e9f000861b4ca
😎 Deploy Preview	https://deploy-preview-36963--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review

Code Review Agent Run #6ec00e

Actionable Suggestions - 1

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts - 1
- Deprecated API Usage · Line 36-40

Review Details

Files reviewed - 2 · Commit Range: 3f38a44..3f38a44
- superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts

bito-code-review · 2026-01-08T02:46:05Z

Code Review Agent Run #ba1917

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: a164e50..a164e50
- superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-08T04:46:15Z

Code Review Agent Run #653b80

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 4d73f0e..4d73f0e
- superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts

geido · 2026-01-08T12:14:52Z

For people who are going to QA this. The Select is used basically everywhere, so we might need to do a sanity check in most pages, including Modals and Popovers.

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts

codeant-ai-for-open-source · 2026-01-08T13:01:29Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

superset-frontend/packages/superset-ui-core/src/components/Select/types.ts

github-actions · 2026-01-08T13:09:49Z

🎪 Showtime is building environment on GHA for 109b61c

github-actions · 2026-01-08T13:25:27Z

🎪 Showtime deployed environment on GHA for 109b61c

• Environment: http://35.90.215.8:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

bito-code-review · 2026-01-08T14:06:35Z

Code Review Agent Run #2e8994

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 109b61c..109b61c
- superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
- superset-frontend/packages/superset-ui-core/src/components/Select/types.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

pull-request-size bot added the size/XS label Jan 8, 2026

github-actions bot added the packages label Jan 8, 2026

dosubot bot added the change:frontend Requires changing the frontend label Jan 8, 2026

bito-code-review bot reviewed Jan 8, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts Outdated Show resolved Hide resolved

reynoldmorel force-pushed the fix/store-location-positioning branch 2 times, most recently from 6e73e3e to a164e50 Compare January 8, 2026 01:52

reynoldmorel force-pushed the fix/store-location-positioning branch 2 times, most recently from fd1b92d to 05bbab3 Compare January 8, 2026 03:47

pull-request-size bot added size/S and removed size/XS labels Jan 8, 2026

reynoldmorel force-pushed the fix/store-location-positioning branch from 05bbab3 to 4d73f0e Compare January 8, 2026 03:48

geido reviewed Jan 8, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts Outdated Show resolved Hide resolved

msyavuz reviewed Jan 8, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts Outdated Show resolved Hide resolved

reynoldmorel force-pushed the fix/store-location-positioning branch from 4d73f0e to 81a9b68 Compare January 8, 2026 13:01

reynoldmorel requested a review from geido January 8, 2026 13:01

reynoldmorel requested a review from msyavuz January 8, 2026 13:01

msyavuz reviewed Jan 8, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/types.ts Outdated Show resolved Hide resolved

fix(dashboard): resolve dropdown popup positioning

109b61c

reynoldmorel force-pushed the fix/store-location-positioning branch from 81a9b68 to 109b61c Compare January 8, 2026 13:07

reynoldmorel requested a review from msyavuz January 8, 2026 13:07

msyavuz added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 8, 2026

github-actions bot removed the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 8, 2026

fix(dashboard): resolve dropdown popup positioning #36963

Are you sure you want to change the base?

fix(dashboard): resolve dropdown popup positioning #36963

Uh oh!

Conversation

reynoldmorel commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 8, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

codeant-ai-for-open-source bot commented Jan 8, 2026

Nitpicks 🔍

Uh oh!

codeant-ai-for-open-source bot commented Jan 8, 2026

Uh oh!

netlify bot commented Jan 8, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #6ec00e

Uh oh!

Uh oh!

bito-code-review bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #ba1917

Uh oh!

bito-code-review bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #653b80

Uh oh!

Uh oh!

geido commented Jan 8, 2026

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 8, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

bito-code-review bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #2e8994

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reynoldmorel commented Jan 8, 2026 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading

bito-code-review bot commented Jan 8, 2026 •

edited

Loading

bito-code-review bot commented Jan 8, 2026 •

edited

Loading

bito-code-review bot commented Jan 8, 2026 •

edited

Loading