fix(charts): numerical column for the Point Radius field in mapbox #36962

FelipeGLopez · 2026-01-08T00:23:14Z

SUMMARY

The code passed raw numerical column values as the base pointRadius for all units (Kilometers, Miles, and Pixels), causing points to render at extreme sizes or disappear entirely.
The fix has two parts:
(1) In transformProps.js, it always uses DEFAULT_POINT_RADIUS as the base radius regardless of unit, then lets individual points get their values from geoJSON properties
(2) In ScatterPlotGlowOverlay.jsx, it adds normalization specifically for Pixels mode (min/max scaling to 5px-radius/3 range), while Kilometers and Miles were already being converted to pixels via computePointRadiusPixels() but now work correctly because they're based on the normalized DEFAULT_POINT_RADIUS instead of raw data values.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Currently, Mapbox does not display anything when a numerical column other than Auto is selected, regardless of the Point Radius Unit.

Before.mov

After:

Here, we select a numerical column (radius_miles), and the points are correctly rendered.

After.mov

TESTING INSTRUCTIONS

Create a MapBox with the sample GeoData dataset
Drag and drop the LON and LAT columns to the respective fields
Go to the Point Radius field and select the radius_miles column
Select miles in the Point Radius Unit field
Click on Update Chart

ADDITIONAL INFORMATION

Has associated issue: MapBox chart doesn't let you properly use a numerical column for the Point Radius field #34398
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codeant-ai-for-open-source · 2026-01-13T14:28:51Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

netlify · 2026-01-13T14:34:01Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`1b6a8f2`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6977b5e70add8b00073ec448
😎 Deploy Preview	https://deploy-preview-36962--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx

codeant-ai-for-open-source · 2026-01-13T14:34:12Z

CodeAnt AI finished reviewing your PR.

bito-code-review · 2026-01-13T15:33:07Z

Code Review Agent Run #6faee1

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: ece6465..01e67cd
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

rusackas · 2026-01-13T18:40:21Z

Would appreciate it if you can check the bot review comments and either reply or address them, and get pre-commit to pass.

The giant circles are a little overwhelmingly large in some cases, but if they're accurate, they're accurate. I wonder if there's a way to set opacity or something to make them more useful in this regard? Then you could see where you are on the map when they cover the whole chart, at least.

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install

A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

codeant-ai-for-open-source · 2026-01-13T23:14:13Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

FelipeGLopez · 2026-01-14T00:03:24Z

Would appreciate it if you can check the bot review comments and either reply or address them, and get pre-commit to pass.

The giant circles are a little overwhelmingly large in some cases, but if they're accurate, they're accurate. I wonder if there's a way to set opacity or something to make them more useful in this regard? Then you could see where you are on the map when they cover the whole chart, at least.

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:
pip3 install -r requirements/development.txt
pre-commit install
A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:
pre-commit run --all-files

Now that you mentioned opacity, I found an issue in the “Visual Tweaks” section. The opacity field is present, but regardless of the value you set, the visual opacity remains the same. I’ll open a separate PR to address this issue.

bito-code-review · 2026-01-14T00:17:31Z

Code Review Agent Run #4cfd2d

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 01e67cd..df1c24c
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

geido · 2026-01-20T16:41:54Z

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx

    const maxLabel = Math.max(...clusterLabelMap.filter(v => !Number.isNaN(v)));

+    // Calculate min/max radius values for Pixels mode scaling
+    let minRadiusValue = Infinity;


Can we add some tests?

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx

bito-code-review · 2026-01-26T19:47:22Z

Code Review Agent Run #c147ba

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: df1c24c..83fce2b
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js
- superset-frontend/plugins/legacy-plugin-chart-map-box/test/ScatterPlotGlowOverlay.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-26T22:19:18Z

Code Review Agent Run #5c6437

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 83fce2b..eb7f1af
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js
- superset-frontend/plugins/legacy-plugin-chart-map-box/test/ScatterPlotGlowOverlay.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

github-actions · 2026-01-28T09:40:00Z

🎪 Showtime is building environment on GHA for eb7f1af

github-actions · 2026-01-28T09:59:44Z

🎪 Showtime deployed environment on GHA for eb7f1af

• Environment: http://34.219.31.62:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

EnxDev

@FelipeGLopez should we add a test to ensure that points remain visible when the radius is set to extreme values?

PS: The test should validate the user-facing behavior, verifying that points are still rendered and accessible from the user’s perspective, rather than asserting on implementation details.

FelipeGLopez · 2026-01-28T17:04:48Z

@FelipeGLopez should we add a test to ensure that points remain visible when the radius is set to extreme values?

PS: The test should validate the user-facing behavior, verifying that points are still rendered and accessible from the user’s perspective, rather than asserting on implementation details.

Yes, you have a point there! I added that missing test and changed the tests.

bito-code-review · 2026-01-28T18:07:26Z

Code Review Agent Run #fd214e

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/plugins/legacy-plugin-chart-map-box/test/ScatterPlotGlowOverlay.test.tsx - 1
- Test assertions insufficient for claimed behavior · Line 86-184
  
  These test changes replace detailed assertions on radius normalization logic with generic 'not.toThrow()' checks. Per repository guidelines, tests should verify actual behavior they claim to test, not just rendering. The test names suggest validation of radius scaling in Pixels mode, but the assertions only confirm no errors occur, allowing potential bugs in calculations to go undetected.

Review Details

Files reviewed - 3 · Commit Range: eb7f1af..8f8bb82
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx
- superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js
- superset-frontend/plugins/legacy-plugin-chart-map-box/test/ScatterPlotGlowOverlay.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

Add calculations for Pixel in map

ece6465

pull-request-size bot added the size/M label Jan 8, 2026

github-actions bot added the plugins label Jan 8, 2026

rusackas added the review:draft label Jan 12, 2026

FelipeGLopez changed the title ~~Add calculations for Pixel in map~~ fix(charts): numerical column for the Point Radius field in mapbox Jan 13, 2026

FelipeGLopez marked this pull request as ready for review January 13, 2026 14:25

Merge branch 'master' into fix/mapbox-point-radius-field

01e67cd

codeant-ai-for-open-source bot reviewed Jan 13, 2026

View reviewed changes

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx Outdated Show resolved Hide resolved

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx Outdated Show resolved Hide resolved

rusackas removed the review:draft label Jan 13, 2026

Address comments

df1c24c

geido reviewed Jan 20, 2026

View reviewed changes

Merge branch 'master' into fix/mapbox-point-radius-field

1b6a8f2

codeant-ai-for-open-source bot reviewed Jan 26, 2026

View reviewed changes

superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx Outdated Show resolved Hide resolved

Add tests

83fce2b

pull-request-size bot added size/L and removed size/M labels Jan 26, 2026

Add tests and address bot comment

eb7f1af

EnxDev added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 28, 2026

github-actions bot added 🎪 eb7f1af 🚦 building Environment eb7f1af status: building and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Jan 28, 2026

github-actions bot added 🎪 eb7f1af 📅 2026-01-28T09-39 Environment eb7f1af created at 2026-01-28T09-39 🎪 eb7f1af 🤡 EnxDev Environment eb7f1af requested by EnxDev 🎪 ⌛ 48h Environment expires after 48 hours (default) labels Jan 28, 2026

EnxDev reviewed Jan 28, 2026

View reviewed changes

Modifiy tests

8f8bb82

github-actions bot added the 🎪 🔒 showtime-blocked label Jan 28, 2026

fix(charts): numerical column for the Point Radius field in mapbox #36962

Are you sure you want to change the base?

fix(charts): numerical column for the Point Radius field in mapbox #36962

Conversation

FelipeGLopez commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 13, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

netlify bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 13, 2026

Uh oh!

bito-code-review bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #6faee1

Uh oh!

rusackas commented Jan 13, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 13, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

FelipeGLopez commented Jan 14, 2026

Uh oh!

bito-code-review bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #4cfd2d

Uh oh!

geido Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bito-code-review bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c147ba

Uh oh!

bito-code-review bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #5c6437

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

EnxDev left a comment

Choose a reason for hiding this comment

Uh oh!

FelipeGLopez commented Jan 28, 2026

Uh oh!

bito-code-review bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #fd214e

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FelipeGLopez commented Jan 8, 2026 •

edited

Loading

netlify bot commented Jan 13, 2026 •

edited

Loading

bito-code-review bot commented Jan 13, 2026 •

edited

Loading

bito-code-review bot commented Jan 14, 2026 •

edited

Loading

bito-code-review bot commented Jan 26, 2026 •

edited

Loading

bito-code-review bot commented Jan 26, 2026 •

edited

Loading

bito-code-review bot commented Jan 28, 2026 •

edited

Loading