fix(dynamic-group-by): scope chart refreshes to affected charts only #36955

LevisNgigi · 2026-01-07T18:26:14Z

SUMMARY

This change prevents request storms caused by Dynamic Group By chart customizations by aligning chart refresh behavior with the existing native filters pattern.
Previously, applying or saving chart customizations triggered a forced re-query of all charts on the dashboard, regardless of whether they were affected. This caused unnecessary request fan-out and excessive /api/v1/chart/data traffic on dashboards with many charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER;

TESTING INSTRUCTIONS

1)Open a dashboard with multiple charts (ideally 10+).
2)Configure Dynamic Group By / Chart Customization for one or more charts.
3)Open the browser DevTools → Network tab (filter by /api/v1/chart/data).
4)Apply the chart customization.

Verify:

1)Only charts affected by the customization issue /api/v1/chart/data requests.
2)Unaffected charts do not re-query.
3)Each affected chart triggers only one request per apply action.
4)No repeated or cascading requests are observed.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codeant-ai-for-open-source · 2026-01-07T18:26:20Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-07T18:26:24Z

Code Review Agent Run #a7fcbb

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: b3e113d..b3e113d
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-07T18:28:42Z

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review Possible Bug The code assumes `getRelatedChartsForChartCustomization` always returns an array of valid chart IDs and directly spreads its result into `affectedChartIds`. If the helper returns `null`, `undefined`, a non-array, or values that are not numeric IDs, this will cause incorrect entries or runtime errors. Add defensive checks and normalize values to numbers before using them to build the affected list. Possible Bug The code calls `getRelatedChartsForChartCustomization(...)` and pushes its result into `affectedChartIds` without validating the return value or element types. If the utility returns undefined, non-array, or non-numeric identifiers, `dispatch(triggerQuery(true, chartId))` may be called with invalid arguments. Also ensure this behavior is correct for customizations that are `removed` (should they still trigger queries?). Potential Dispatch Storm Even after narrowing down to related charts, the code dispatches a `triggerQuery` for every affected chart in a tight loop. For dashboards with many affected charts this can still cause many simultaneous requests. Consider filtering to existing slices, batching, or otherwise limiting concurrency.

superset-frontend/src/dashboard/actions/chartCustomizationActions.ts

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

codeant-ai-for-open-source · 2026-01-07T18:28:57Z

CodeAnt AI finished reviewing your PR.

netlify · 2026-01-07T18:29:26Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`ee76300`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695f99a76b8f8900085c6097
😎 Deploy Preview	https://deploy-preview-36955--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review · 2026-01-07T19:50:29Z

Code Review Agent Run #e57967

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: b3e113d..497a574
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

superset-frontend/src/dashboard/actions/chartCustomizationActions.ts

bito-code-review · 2026-01-07T22:06:10Z

Code Review Agent Run #4ba813

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 497a574..9d222f4
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
- superset-frontend/src/dashboard/util/getRelatedCharts.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

github-actions · 2026-01-08T11:07:15Z

🎪 Showtime is building environment on GHA for 9d222f4

geido · 2026-01-08T11:08:58Z

Can we add some test cases?

github-actions · 2026-01-08T18:05:48Z

🎪 Showtime deployed environment on GHA for c3b83fd

• Environment: http://35.85.215.129:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

codeant-ai-for-open-source · 2026-01-08T21:06:58Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review

Code Review Agent Run #715f0f

Actionable Suggestions - 1

superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx - 1
- Faulty fetch deduplication logic · Line 441-446

Additional Suggestions - 1

superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/ChartCustomizationForm.tsx - 1
- Race condition in async fetch · Line 432-437
  
  The async fetch logic has a race condition: if the dataset changes while a fetch is in progress, the old fetch may complete later and overwrite the state with stale data. To fix, track the current fetching dataset ID and only apply state updates if they match.

Review Details

Files reviewed - 7 · Commit Range: ee76300..9eed291
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/ChartCustomizationForm.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
- superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.test.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

...set-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx

codeant-ai-for-open-source · 2026-01-09T05:54:09Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-09T06:58:30Z

Code Review Agent Run #38263c

Actionable Suggestions - 0

Review Details

Files reviewed - 7 · Commit Range: 9eed291..5a7667f
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/ChartCustomizationForm.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
- superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.test.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

geido · 2026-01-09T10:50:35Z

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

+        const previouslyAffectedChartIds: number[] = [];
+        const originalCustomizations = chartCustomizationItems || [];
+
+        originalCustomizations.forEach(oldItem => {


This whole logic seems fragile to me. It definitely needs some drying up also.

codeant-ai-for-open-source · 2026-01-11T07:17:28Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-11T08:18:45Z

Code Review Agent Run #6c5b7e

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/utils.ts - 1
- Logic error in validation · Line 90-90
  
  The return statement here unconditionally returns true for any non-string, non-array value, but the JSDoc specifies that only 'truthy values' are valid. This could incorrectly validate falsy values like 0 or false. Update to 'return !!column;' to align with the documented behavior.
  Code suggestion
  @@ -86,5 +86,5 @@ - if (Array.isArray(column)) { - return column.length > 0; - } - - return true; + if (Array.isArray(column)) { + return column.length > 0; + } + + return !!column;

Review Details

Files reviewed - 8 · Commit Range: 5a7667f..d07daf9
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/ChartCustomizationForm.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/utils.ts
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
- superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.test.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-11T09:22:45Z

Code Review Agent Run #3bc615

Actionable Suggestions - 0

Review Details

Files reviewed - 8 · Commit Range: d07daf9..14eb0ce
- superset-frontend/src/dashboard/actions/chartCustomizationActions.ts
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/ChartCustomizationForm.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx
- superset-frontend/src/dashboard/components/nativeFilters/ChartCustomization/utils.ts
- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
- superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.test.ts
- superset-frontend/src/dashboard/util/getRelatedCharts.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

fix-request-storms

b3e113d

pull-request-size bot added the size/M label Jan 7, 2026

dosubot bot added the dashboard:performance Related to Dashboard performance label Jan 7, 2026

codeant-ai-for-open-source bot reviewed Jan 7, 2026

View reviewed changes

superset-frontend/src/dashboard/actions/chartCustomizationActions.ts Outdated Show resolved Hide resolved

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx Outdated Show resolved Hide resolved

fix-request-storms

497a574

gabotorresruiz reviewed Jan 7, 2026

View reviewed changes

superset-frontend/src/dashboard/actions/chartCustomizationActions.ts Outdated Show resolved Hide resolved

dry-up

9d222f4

LevisNgigi closed this Jan 7, 2026

LevisNgigi reopened this Jan 7, 2026

gabotorresruiz approved these changes Jan 7, 2026

View reviewed changes

geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 8, 2026

fix-fetching-logic

9eed291

pull-request-size bot removed the size/L label Jan 8, 2026

pull-request-size bot added the size/XL label Jan 8, 2026

github-actions bot added the 🎪 🔒 showtime-blocked label Jan 8, 2026

bito-code-review bot reviewed Jan 8, 2026

View reviewed changes

...set-frontend/src/dashboard/components/nativeFilters/ChartCustomization/GroupByFilterCard.tsx Outdated Show resolved Hide resolved

fix-fetching-logic

5a7667f

geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 9, 2026

geido reviewed Jan 9, 2026

View reviewed changes

fix reviews

d07daf9

fix-reduce-requests

14eb0ce

fix(dynamic-group-by): scope chart refreshes to affected charts only #36955

Are you sure you want to change the base?

fix(dynamic-group-by): scope chart refreshes to affected charts only #36955

Conversation

LevisNgigi commented Jan 7, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #a7fcbb

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Nitpicks 🔍

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Uh oh!

netlify bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #e57967

Uh oh!

Uh oh!

bito-code-review bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #4ba813

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

geido commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 8, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #715f0f

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 9, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #38263c

Uh oh!

Uh oh!

Uh oh!

geido Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source bot commented Jan 11, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #6c5b7e

Uh oh!

bito-code-review bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3bc615

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

bito-code-review bot commented Jan 7, 2026 •

edited

Loading

netlify bot commented Jan 7, 2026 •

edited

Loading

bito-code-review bot commented Jan 7, 2026 •

edited

Loading

bito-code-review bot commented Jan 7, 2026 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading

bito-code-review bot commented Jan 9, 2026 •

edited

Loading

bito-code-review bot commented Jan 11, 2026 •

edited

Loading

bito-code-review bot commented Jan 11, 2026 •

edited

Loading