fix(config): Wire LOGO_TARGET_PATH and document custom spinner usage

[shashbha14]

SUMMARY
This PR addresses user confusion regarding customizing the loading icon and resolves a bug where LOGO_TARGET_PATH was being ignored by the default theme system in Superset 6.0.0.

Specifically, it:

1. Documents Custom Loading Icon: Explicitly documents brandSpinnerUrl in THEME_DEFAULT within config.py. This clarifies that users can set a custom GIF/image loader via config without needing to replace source files or rebuild assets.
2. Fixes Logo Link: Updates THEME_DEFAULT to correctly use LOGO_TARGET_PATH for brandLogoHref. Previously, LOGO_TARGET_PATH was ignored by the default theme, forcing users to override the entire theme object just to change the logo link.
3. Clarifies Configuration: Added comments to APP_ICON, LOGO_TOOLTIP, LOGO_RIGHT_TEXT, and APP_ICON_WIDTH (deprecation note) to clarify their interaction with THEME_DEFAULT or their deprecated status.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (Configuration and Documentation changes only)

TESTING INSTRUCTIONS
To verify these changes locally:

1. Verify Logo Link Fix:

   • In superset_config.py, set LOGO_TARGET_PATH = "https://custom.url".
   • Restart Superset and click the top-left logo.
   • Result: It should navigate to https://custom.url (previously it would stay on / unless the theme was overridden).

2. Verify Custom Spinner:

   • In superset_config.py, set:

     THEME_DEFAULT = {
         "token": {
             "brandSpinnerUrl": "/static/assets/images/my-custom-spinner.gif"
         }
     }

   • Restart Superset.
   • Result: The custom GIF should appear during loading.

ADDITIONAL INFORMATION

• Has associated issue: Fixes Theming Error: Facing issue in Changing App Icon and Loading icon in Apache Superset 6.0.0 #36940
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #3272be

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 4e6b533..4e6b533

  • superset/config.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	4e6b533
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695e4b3c25d1df00089b71ec
😎 Deploy Preview	https://deploy-preview-36951--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[rusackas]

Looks simple enough, but can you perhaps add a simple test where you add a LOGO_TARGET_PATH and assert that it shows up in the code?

[Copilot]

Pull request overview

This PR fixes a bug where the LOGO_TARGET_PATH configuration variable was ignored by the default theme system, and improves documentation around custom loading icons and logo configuration.

Changes:

• Fixed LOGO_TARGET_PATH to be properly wired into THEME_DEFAULT["token"]["brandLogoHref"]
• Documented the brandSpinnerUrl configuration option for custom loading icons
• Added clarifying comments about how APP_ICON, LOGO_TARGET_PATH, LOGO_TOOLTIP, and LOGO_RIGHT_TEXT interact with the theme system

[Copilot]

There is a typo in this comment. The word "user" should not have an apostrophe at the end.

Suggested change

	# Specify where clicking the logo would take the user'
	# Specify where clicking the logo would take the user

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.17%. Comparing base (9968393) to head (4e6b533).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #36951       +/-   ##
===========================================
+ Coverage        0   68.17%   +68.17%     
===========================================
  Files           0      639      +639     
  Lines           0    47657    +47657     
  Branches        0     5204     +5204     
===========================================
+ Hits            0    32491    +32491     
- Misses          0    13886    +13886     
- Partials        0     1280     +1280     

Flag	Coverage Δ
hive	43.09% <ø> (?)
mysql	66.18% <ø> (?)
postgres	66.23% <ø> (?)
presto	46.69% <ø> (?)
python	68.14% <ø> (?)
sqlite	65.94% <ø> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.