fix(viz): display offset metrics as dashed lines regardless of compar… #36923

anumukul · 2026-01-06T10:57:25Z

SUMMARY

This PR fixes a regression where offset metrics (time comparisons like "1 year ago") were not displayed as dashed lines when charts have no dimensions.

Root Cause:
The isDerivedSeries function only applied dashed styling when comparison_type === "Values", and hasTimeOffset didn't detect series where the name exactly matched a time offset (which happens when there are no dimensions).

Changes:

Removed the restrictive comparison_type === "Values" check in isDerivedSeries.ts
Added exact match handling in timeOffset.ts for dimension-less charts
Updated tests to reflect new behavior

BEFORE/AFTER

BEFORE

**AFTER **

TESTING INSTRUCTIONS

Create a new Line Chart
Select a dataset with a time column (e.g., birth_names with ds)
Add a metric (e.g., COUNT(*))
Set Time Range to a valid range (e.g., 2005-01-01 to 2008-12-31)
In Advanced Analytics, add Time Comparison: 1 year ago
Do NOT add any dimensions (leave Dimensions empty)
Click "Update Chart"
Verify the offset metric line (1 year ago) appears dashed, not solid

ADDITIONAL INFORMATION

Has associated issue: Fixes Offset metrics are not displayed as dashed lines on line chart in version 6.0.0. #36806
Required feature flags: None
Changes UI
Includes DB Migration
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…ison_type This fixes a regression where offset metrics (time comparisons like '1 year ago') were not displayed as dashed lines when: - comparison_type was not set to 'Values' - the chart had no dimensions Changes: - Remove comparison_type check in isDerivedSeries.ts - Add exact match handling in timeOffset.ts for dimension-less charts - Update tests to reflect new behavior Fixes apache#36806

codeant-ai-for-open-source · 2026-01-06T10:57:30Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

netlify · 2026-01-06T10:57:31Z

✅ Deploy Preview for superset-docs-preview canceled.

Name	Link
🔨 Latest commit	`845701e`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695cea981190d60008f288ce

bito-code-review · 2026-01-06T10:57:37Z

Code Review Agent Run #ff9a91

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 845701e..845701e
- superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/isDerivedSeries.ts
- superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/timeOffset.ts
- superset-frontend/packages/superset-ui-chart-controls/test/operators/utils/isDerivedSeries.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-06T11:00:08Z

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review Behavioral change The removed guard that required `comparison_type === ComparisonType.Values` means any chart with a `time_compare` entry may now mark series as derived. Verify this doesn't enable dashed styling for other comparison types unintentionally. Confirm desired behavior across all supported `comparison_type` values. getTimeOffset guard The exported helper `getTimeOffset` assumes `series.name` is a string (it calls `.includes`), but it has no internal type guard. While `hasTimeOffset` now checks the type before calling it, other call sites could call `getTimeOffset` directly and trigger a runtime error if `series.name` is undefined or non-string. Consider making `getTimeOffset` defensive about `series.name` or narrow its parameter type. Behavior change Removing the restriction that only ComparisonType.Values marks a derived series means series whose names match time offsets will now be treated as derived regardless of the configured comparison_type. This can change visual styling (dashed vs solid lines) in other comparison modes; verify this is intended across chart types and UI surface. Matching robustness The new exact-match check (`timeCompare.includes(series.name)`) in `hasTimeOffset` fixes a regression but can still miss matches due to leading/trailing whitespace or minor formatting differences. Also, logic is split between `getTimeOffset` (pattern matches) and `hasTimeOffset` (exact match), which may lead to maintenance churn. Consider centralizing and normalizing comparisons (trim/case) and consolidating matching logic. Viz type clarity The shared `formData` uses `VizType.Table`. The regression being fixed relates to charts with no dimensions (e.g. line charts); confirm tests reflect the intended chart type or add explicit tests for relevant viz types so behavior for dimension-less charts is validated.

superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/isDerivedSeries.ts

codeant-ai-for-open-source · 2026-01-06T11:00:27Z

superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/timeOffset.ts

 ): boolean =>
  typeof series.name === 'string'
-    ? !!getTimeOffset(series, timeCompare)
+    ? !!getTimeOffset(series, timeCompare) || timeCompare.includes(series.name)
    : false;


Suggestion: Performance bug: calling getTimeOffset (which scans timeCompare) and then calling timeCompare.includes(...) performs two separate linear scans over timeCompare; compute the offset once and reuse the result to avoid the duplicate O(n) work. [performance]

Severity Level: Minor ⚠️

Suggested change

): boolean =>

typeof series.name === 'string'

? !!getTimeOffset(series, timeCompare)

? !!getTimeOffset(series, timeCompare) || timeCompare.includes(series.name)

: false;

): boolean => {

if (typeof series.name !== 'string') return false;

const foundOffset = getTimeOffset(series, timeCompare);

if (foundOffset) return true;

return Array.isArray(timeCompare) && timeCompare.includes(series.name);

};

Why it matters? ⭐

Calling getTimeOffset (which iterates timeCompare) and then timeCompare.includes(...) results in two linear scans. Caching the result of getTimeOffset and reusing it avoids the duplicate O(n) work with no behavioral change, so this is a valid micro-optimization.

Prompt for AI Agent 🤖

This is a comment left during a code review. **Path:** superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/timeOffset.ts **Line:** 37:40 **Comment:** *Performance: Performance bug: calling `getTimeOffset` (which scans `timeCompare`) and then calling `timeCompare.includes(...)` performs two separate linear scans over `timeCompare`; compute the offset once and reuse the result to avoid the duplicate O(n) work. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

codeant-ai-for-open-source · 2026-01-06T11:00:32Z

CodeAnt AI finished reviewing your PR.

…ators/utils/isDerivedSeries.ts Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

codeant-ai-for-open-source · 2026-01-07T11:48:53Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

…ators/utils/isDerivedSeries.ts Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

bito-code-review · 2026-01-07T12:50:35Z

Code Review Agent Run #e4959d

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 845701e..94997dd
- superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/isDerivedSeries.ts
- superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/timeOffset.ts
- superset-frontend/packages/superset-ui-chart-controls/test/operators/utils/isDerivedSeries.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

justinpark

LGTM

pull-request-size bot added the size/M label Jan 6, 2026

github-actions bot added the packages label Jan 6, 2026

dosubot bot added the viz:charts Namespace | Anything related to viz types label Jan 6, 2026

codeant-ai-for-open-source bot reviewed Jan 6, 2026

View reviewed changes

Update superset-frontend/packages/superset-ui-chart-controls/src/oper…

ff3e5e0

…ators/utils/isDerivedSeries.ts Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

Update superset-frontend/packages/superset-ui-chart-controls/src/oper…

94997dd

…ators/utils/isDerivedSeries.ts Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

sadpandajoe requested review from eschutho, hainenber and justinpark January 8, 2026 19:28

justinpark approved these changes Jan 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(viz): display offset metrics as dashed lines regardless of compar… #36923

fix(viz): display offset metrics as dashed lines regardless of compar… #36923

anumukul commented Jan 6, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Uh oh!

netlify bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

bito-code-review bot commented Jan 6, 2026 •

edited

Loading

Code Review Agent Run #ff9a91

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot Jan 6, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Uh oh!

bito-code-review bot commented Jan 7, 2026 •

edited

Loading

Code Review Agent Run #e4959d

Uh oh!

justinpark left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(viz): display offset metrics as dashed lines regardless of compar… #36923

Are you sure you want to change the base?

fix(viz): display offset metrics as dashed lines regardless of compar… #36923

Conversation

anumukul commented Jan 6, 2026

SUMMARY

BEFORE/AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview canceled.

Uh oh!

bito-code-review bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #ff9a91

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Nitpicks 🔍

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source bot commented Jan 6, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #e4959d

Uh oh!

justinpark left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 6, 2026 •

edited

Loading

bito-code-review bot commented Jan 6, 2026 •

edited

Loading

bito-code-review bot commented Jan 7, 2026 •

edited

Loading