Fixing some warnings during tests #3648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs
This removes a warning during yarn tests Fix apache#3589
```
Warning: Failed prop type: The prop `query` is marked as required in
`QueryStateLabel`, but its value is `undefined`.
in QueryStateLabel
```
This removes a warning during yarn tests: ``` Warning: Failed prop type: Invalid prop `target` supplied to `Overlay`. ```
This removes a warning during yarn tests: ``` Warning: Failed prop type: The prop `queryState` is marked as required in `RunQueryActionButton`, but its value is `null`. ```
1 similar comment
|
LGTM. THANK YOU! |
eddy-geek
added a commit
to eddy-geek/incubator-superset
that referenced
this pull request
Oct 15, 2017
…t_box * remotes/origin/master: (340 commits) [New Viz] Partition Diagram (apache#3642) Add description for running specific test (apache#3665) Making the sort order for metrics pull from fd for time table viz (apache#3661) Make columns that return an exception on click unsortable. (apache#3417) Adding sort time table (apache#3651) added aihello as superset user. (apache#3647) Fix apache#3612 - reverse sign in difference calculation (apache#3646) Fixing some warnings during tests (apache#3648) [Translations] Restored lost French translations (apache#3645) [sql lab] fix impersonation + template issue (apache#3644) Pin moment.js library since 2.19.0 creates problem (apache#3641) [time_table] adding support for URLs / links (apache#3600) Set tooltip to show extent of sparkData (apache#3626) add explicit message display for 'Fetching Annotation Layer' error (apache#3631) [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637) fix long title text wrapping in editable-title component (apache#3638) [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625) add annotation option and a linear color map for heatmap viz. (apache#3634) [bugfix] empty From date filter NoneType error (apache#3633) remove unused imports (apache#3621) ...
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* ColorSchemeControl: fixing bad use of PropTypes Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs * Control: adding PropTypes.func in types allowed inside `value` prop This removes a warning during yarn tests Fix apache#3589 * tests(QueryStateLabel): removing missing prop warning ``` Warning: Failed prop type: The prop `query` is marked as required in `QueryStateLabel`, but its value is `undefined`. in QueryStateLabel ``` * SaveQuery: removing invalid prop `target` supplied to `Overlay`. This removes a warning during yarn tests: ``` Warning: Failed prop type: Invalid prop `target` supplied to `Overlay`. ``` * RunQueryActionButton: removing `isRequired` from queryState props This removes a warning during yarn tests: ``` Warning: Failed prop type: The prop `queryState` is marked as required in `RunQueryActionButton`, but its value is `null`. ```
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some warnings during
yarn test.ColorSchemeControl: fixing bad use of PropTypes
Accessing PropTypes via the main React package is deprecated, and will be
removed in React v16.0. Use the latest available v15.* prop-types package from
npm instead. For info on usage, compatibility, migration and more, see
https://fb.me/prop-types-docs
Control: adding PropTypes.func in types allowed inside
valuepropThis removes a warning during yarn tests
Fix Warning during assets tests: Failed prop type: Invalid prop
valuesupplied toControl. #3589tests(QueryStateLabel): removing missing prop warning
SaveQuery: removing invalid prop
targetsupplied toOverlay.This removes a warning during yarn tests:
RunQueryActionButton: removing
isRequiredfrom queryState propsThis removes a warning during yarn tests: