Skip to content

Conversation

@rusackas
Copy link
Member

@rusackas rusackas commented Dec 3, 2025

User description

Summary

This PR removes geostyler-qgis-parser from direct dependencies as it's never used directly in the codebase and is already included as a transitive dependency through geostyler.

Analysis

After investigating the codebase:

  • No direct imports: Zero imports of geostyler-qgis-parser found anywhere in the codebase
  • Already a sub-dependency: The geostyler package (^14.1.3) already includes geostyler-qgis-parser (^2.0.0) as a dependency
  • Redundant specification: Having it as both a direct and transitive dependency is unnecessary

Changes

  • Removed geostyler-qgis-parser (2.0.1) from package.json direct dependencies
  • Updated package-lock.json accordingly
  • The package remains available through geostyler's dependencies

Testing

  • Run npm install to verify dependencies resolve correctly
  • Verify map/geostyler functionality still works (the package is still available as a transitive dependency)
  • No functionality changes expected as the package was never directly imported

Benefits

  • Cleaner dependency tree
  • Reduces maintenance burden (one less direct dependency to track)
  • Lets npm/yarn handle version resolution through the parent package
  • Follows best practices of not declaring unused direct dependencies

🤖 Generated with Claude Code


CodeAnt-AI Description

Remove unused direct dependency geostyler-qgis-parser

What Changed

  • Removed geostyler-qgis-parser from package.json and package-lock.json so it is no longer a direct dependency
  • The parser remains available transitively via the geostyler package, so map/geostyler features are unchanged
  • Updated lockfile to reflect the dependency removal; installs should resolve the same runtime packages

Impact

✅ Fewer direct dependencies
✅ Cleaner package.json and lockfile
✅ Unchanged map and geostyler behavior

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

The geostyler-qgis-parser package was listed as a direct dependency but is never
imported or used directly in the codebase. It's already included as a transitive
dependency through geostyler (^14.1.3), which specifies geostyler-qgis-parser ^2.0.0.

Changes:
- Removed geostyler-qgis-parser from package.json direct dependencies
- Updated package-lock.json accordingly
- The package remains available through geostyler's dependencies

This cleanup reduces unnecessary direct dependencies while maintaining functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Dec 3, 2025

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

@rusackas rusackas merged commit e1a8886 into master Dec 4, 2025
69 of 70 checks passed
@rusackas rusackas deleted the chore/remove-unused-geostyler-qgis-parser branch December 4, 2025 20:31
Facyla pushed a commit to Facyla/superset-contrib that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants