fix(SaveModal): reset chart state when saving and going to a dashboard

[msyavuz]

SUMMARY

When saving a chart from the explore view and choosing "Save & go to dashboard", the chart's state from the explore view was persisting in Redux store and affecting the dashboard's chart rendering. This fix ensures that the chart state is properly cleaned up before navigating to the dashboard.

The issue occurs because the explore view's chart state remains in Redux when navigating directly to a dashboard. By dispatching removeChartState before navigation, we ensure a clean state transition.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A - This is a state management fix that prevents incorrect chart rendering

TESTING INSTRUCTIONS

1. Go to explore view and create/edit a chart
2. Click "Save"
3. Select a dashboard from the dropdown
4. Click "Save & go to dashboard"
5. Verify that the chart renders correctly in the dashboard without any state issues from the explore view

Unit Test:
A new unit test has been added to verify that removeChartState is dispatched when saving and navigating to a dashboard. Run:

npm run test -- src/explore/components/SaveModal.test.jsx -t "dispatches removeChartState"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI (prevents chart rendering issues)
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Prevent saved chart settings in Explore from leaking into the dashboard view

What Changed

• When using “Save & go to dashboard” from Explore, the temporary chart state from Explore is cleared before opening the dashboard so the chart renders with the dashboard’s own settings
• Added an automated test to ensure the chart state is cleared and navigation to the dashboard still works as expected

Impact

✅ Correct chart rendering after Save & go to dashboard
✅ Fewer stale explore settings appearing on dashboards
✅ More reliable dashboard view after saving charts

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

[bito-code-review]

Code Review Agent Run #5ca936

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: c61be6d..2d4f0ed

  • superset-frontend/src/explore/components/SaveModal.test.jsx
  • superset-frontend/src/explore/components/SaveModal.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Possible Bug The test that spies on dashboardStateActions.removeChartState also calls dashboardStateActions.removeChartState(chartId) inside an assertion. This additional call can cause the spy assertion to pass even if saveOrOverwrite never invokes removeChartState, weakening the test and potentially hiding regressions in the cleanup logic.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[alexandrusoare]

LGTM - I will test it locally as well