fix(explore): Fixing #36267 by setting pageSizeOptions to constant [50]

[durban77]

User description

SUMMARY

DrillDetails uses fixed 50 for paging. The options on the UI allows the default 5/15/25/50/100 selection, that caused misbehaviour with other than 50 per page settings.
The easiest way to fix this is to remove the possibility to change the pageSize.
My approach is tho set the pageSizeOptions to overwrite the default values with an only 50 per page option.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER

there is only the 50/page option remained

TESTING INSTRUCTIONS

• You'll need to enable the drill to details functionality.
• Right click on a chart with data and select drill to details option.
• The appearing table must have a paging part on the bottom and a page size selector listbox on the right.
• Before the modification, the options include 5/15/25/50/100 per page options.
• After the modification, only 50 per page option remains.

ADDITIONAL INFORMATION

• Has associated issue: DrillDetailTable's pageSize is 50, but the pageSizeOptions allows the default 5,15,25,50,100 #36267
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Fix drill-to-details table to always use 50 rows per page

What Changed

• The drill-to-details table now always shows "50 rows per page" as the only page-size option
• Pagination when drilling into chart data consistently uses 50 rows per page and cannot be changed by the user
• Empty-state and loading behavior for the drill table remain unchanged; table rendering and record counts continue to display normally

Impact

✅ Consistent 50-row pages in drill-to-details
✅ Fewer pagination mismatches when drilling into charts
✅ Clearer, predictable drill results

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[bito-code-review]

Code Review Agent Run #f28353

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 256d7b1..256d7b1

  • superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

Should we fix the ability to select page size, rather than removing the option?

[durban77]

Should we fix the ability to select page size, rather than removing the option?

You are right, that would be the right to do, but I can't do that. I have a limited skillset in this area, with only some hours to spend on this bug, so that's why my fix is based on the easiest option that does the job.

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Magic literal / duplication The literal '50' is duplicated: the PAGE_SIZE constant is already defined and used for defaultPageSize. Using a raw literal here increases risk of divergence if the constant changes later. Prefer reusing the PAGE_SIZE constant to keep behavior consistent.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[netlify]

✅ Deploy Preview for superset-docs-preview canceled.

Name	Link
🔨 Latest commit	fe9f3f4
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/695cc75be5d1300008496d73

[codeant-ai-for-open-source]

CodeAnt AI is running Incremental review

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[rusackas]

I don't think removing all the page size options is the right fix, so I'm inclined to block this. Open to a proper fix still, so I'll leave the PR open for now. Maybe see if Claude Code can take a crack at it? :D

[durban77]

I lack the skills and resources to do so and fix this bug properly.

[bito-code-review]

Code Review Agent Run #6d6396

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 256d7b1..8b6cdfa

  • superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

Closed in favor of #37975 which seems to do all the right stuff. If anyone finds differently, let's open a new Issue/PR off master as it now stands.