Skip to content

fix(chart): align legend with chart grid in List mode for Top/Bottom orientations #36077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnxDev merged 3 commits into from
Nov 14, 2025
+10 −1
Merged

fix(chart): align legend with chart grid in List mode for Top/Bottom orientations #36077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6e41ad
fix(chart): align legend with chart grid in List mode for Top/Bottom …
richardfogaca Nov 12, 2025
13eee5f
Update superset-frontend/plugins/plugin-chart-echarts/src/utils/serie…
richardfogaca Nov 13, 2025
b2b27d7
fix(chart): restore top/right legend positioning for Top orientation
richardfogaca Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const legendTypeControl: ControlSetItem = {
label: t('Type'),
choices: [
['scroll', t('Scroll')],
['plain', t('Plain')],
['plain', t('List')],
],
Copy link
Contributor

@alexandrusoare alexandrusoare Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the name, if we want to display List, maybe we should also name the option list.

Copy link
Contributor Author

@richardfogaca richardfogaca Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexandrusoare , the change to List actually was a request from Sophie. Regarding the mapping plain value, I believe we should keep it because that is actually the echarts legend type option, this way we wouldn't affect echarts behavior

default: legendType,
renderTrigger: true,
Expand Down
9 changes: 9 additions & 0 deletions superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,17 @@ export function getLegendProps(
break;
case LegendOrientation.Bottom:
legend.bottom = 0;
if (padding?.left) {
legend.left = padding.left;
}
break;
case LegendOrientation.Top:
legend.top = 0;
legend.right = zoomable ? TIMESERIES_CONSTANTS.legendTopRightOffset : 0;
if (padding?.left) {
legend.left = padding.left;
}
break;
default:
legend.top = 0;
legend.right = zoomable ? TIMESERIES_CONSTANTS.legendTopRightOffset : 0;
Expand Down
Loading